From: Joe Perches <joe@perches.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>,
David Miller <davem@davemloft.net>,
swise@opengridcomputing.com, rdreier@cisco.com,
shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message
Date: Wed, 09 Jul 2008 11:20:49 -0700 [thread overview]
Message-ID: <1215627649.5553.265.camel@localhost> (raw)
In-Reply-To: <20080709105631.492f86bd@infradead.org>
On Wed, 2008-07-09 at 10:56 -0700, Arjan van de Ven wrote:
> I don't like the size_t... size_t is an abstraction to deal with file
> sizes.... but there's nothing else wrong with using an int for numbers.
<pedant_mode>
o size_t is an abstraction to deal with arbitrary sizes
o an unnecessary <= 0 test exists
o using sizeof(drivername) reduces a dependency on a magic number
o netdev_drivername calls strlcpy with implicit cast to size_t
$ grep strlcpy include/linux/string.h
size_t strlcpy(char *, const char *, size_t);
Your choice. Cheers, Joe
next prev parent reply other threads:[~2008-07-09 18:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 20:08 Printing the driver name as part of the netdev watchdog message Arjan van de Ven
2008-07-06 22:53 ` David Miller
2008-07-06 23:56 ` Arjan van de Ven
2008-07-07 1:51 ` Wang Chen
2008-07-07 3:59 ` David Miller
2008-07-07 4:34 ` Arjan van de Ven
2008-07-07 4:49 ` David Miller
2008-07-07 4:57 ` Arjan van de Ven
2008-07-07 6:44 ` David Miller
2008-07-07 15:23 ` Arjan van de Ven
2008-07-07 1:08 ` Stephen Hemminger
2008-07-07 1:22 ` David Miller
2008-07-07 1:53 ` Jeff Garzik
2008-07-07 17:05 ` Stephen Hemminger
2008-07-07 22:45 ` Roland Dreier
2008-07-07 22:57 ` David Miller
2008-07-07 23:14 ` Roland Dreier
2008-07-07 23:44 ` Stephen Hemminger
2008-07-08 0:10 ` Arjan van de Ven
2008-07-08 19:13 ` Steve Wise
2008-07-08 21:31 ` David Miller
2008-07-08 21:47 ` Arjan van de Ven
2008-07-08 21:57 ` David Miller
2008-07-08 23:48 ` Arjan van de Ven
2008-07-08 23:53 ` David Miller
2008-07-09 0:17 ` Arjan van de Ven
2008-07-09 1:44 ` Arjan van de Ven
2008-07-09 3:16 ` Stephen Hemminger
2008-07-09 17:20 ` Joe Perches
2008-07-09 17:56 ` Arjan van de Ven
2008-07-09 18:20 ` Joe Perches [this message]
2008-07-09 18:50 ` Arjan van de Ven
2008-07-09 18:28 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215627649.5553.265.camel@localhost \
--to=joe@perches.com \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).