From: Travis Stratman <tstratman@emacinc.com>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org
Subject: Re: data received but not detected
Date: Tue, 15 Jul 2008 15:46:24 -0500 [thread overview]
Message-ID: <1216154784.3084.151.camel@cheeto.emacinc.com> (raw)
In-Reply-To: <4873356F.5080402@katalix.com>
On Tue, 2008-07-08 at 10:37 +0100, James Chapman wrote:
>
> The rx and tx status are flagged in the same status register. The bits
> are set regardless of whether rx or tx interrupts are enabled in the
> device. So when you handle a tx interrupt, the interrupt routine will
> read the status register and may see rx bits also set.
That makes sense, I was making an incorrect assumption.
>
> You could mask the status register value that you read to ignore rx bits
> if rx interrupts are disabled (NAPI polled mode). But to be honest, I
> think it is simpler to handle rx _and_ tx work in the NAPI poll handler
> so you only get interrupts when not in NAPI polled mode. See tg3.c or
> e100.c for example.
I will take a look at modifying the driver to use NAPI for tx.
Thanks,
Travis
next prev parent reply other threads:[~2008-07-15 20:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 22:08 data received but not detected Travis Stratman
2008-06-17 22:27 ` Stephen Hemminger
2008-06-17 22:40 ` Travis Stratman
2008-06-17 22:31 ` Ben Greear
2008-06-17 22:58 ` Travis Stratman
2008-06-17 23:45 ` Ben Greear
2008-06-19 22:53 ` Travis Stratman
2008-06-19 23:08 ` Ben Greear
2008-06-22 9:16 ` James Chapman
2008-07-07 21:56 ` Travis Stratman
2008-07-08 9:37 ` James Chapman
2008-07-15 20:46 ` Travis Stratman [this message]
2008-06-18 6:28 ` Evgeniy Polyakov
2008-06-19 23:10 ` Travis Stratman
[not found] ` <20080620060219.GA22784@2ka.mipt.ru>
2008-06-20 17:10 ` Travis Stratman
2008-06-20 17:25 ` Evgeniy Polyakov
2008-06-20 17:41 ` Travis Stratman
2008-06-20 17:54 ` Evgeniy Polyakov
2008-06-20 18:17 ` Travis Stratman
2008-06-20 18:23 ` Evgeniy Polyakov
2008-06-20 21:06 ` Travis Stratman
2008-06-21 7:12 ` Evgeniy Polyakov
2008-07-07 21:10 ` Travis Stratman
2008-07-07 21:25 ` Evgeniy Polyakov
2008-07-15 20:43 ` Travis Stratman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216154784.3084.151.camel@cheeto.emacinc.com \
--to=tstratman@emacinc.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).