* [PATCH] IPVS: More reliable subchronization on connection close.
@ 2008-07-16 6:35 Simon Horman
2008-07-16 19:49 ` Rumen Bogdanovski
2008-07-17 2:47 ` [PATCH] IPVS: More reliable synchronization " Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Simon Horman @ 2008-07-16 6:35 UTC (permalink / raw)
To: LVS Devel, Linux Netdev List
Cc: David Miller, Rumen Bogdanovski, Joseph Mack NA3T
From: Rumen Bogdanovski <rumen@voicecho.com>
This patch enhances the synchronization of the closing connections
between the master and the backup director. It prevents the closed
connections to expire with the 15 min timeout of the ESTABLISHED
state on the backup and makes them expire as they would do on the
master with much shorter timeouts.
Cc: Joseph Mack NA3T <jmack@wm7d.net>
Signed-off-by: Rumen G. Bogdanovski <rumen@voicecho.com>
Acked-by: Simon Horman <horms@verge.net.au>
---
Hi Dave,
please consider applying this.
diff -Naur net-2.6_orig/net/ipv4/ipvs/ip_vs_core.c net-2.6/net/ipv4/ipvs/ip_vs_core.c
--- net-2.6_orig/net/ipv4/ipvs/ip_vs_core.c 2008-07-15 11:23:44.000000000 +0300
+++ net-2.6/net/ipv4/ipvs/ip_vs_core.c 2008-07-15 11:27:31.000000000 +0300
@@ -993,7 +993,8 @@
== sysctl_ip_vs_sync_threshold[0])) ||
((cp->protocol == IPPROTO_TCP) && (cp->old_state != cp->state) &&
((cp->state == IP_VS_TCP_S_FIN_WAIT) ||
- (cp->state == IP_VS_TCP_S_CLOSE)))))
+ (cp->state == IP_VS_TCP_S_CLOSE_WAIT) ||
+ (cp->state == IP_VS_TCP_S_TIME_WAIT)))))
ip_vs_sync_conn(cp);
cp->old_state = cp->state;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IPVS: More reliable subchronization on connection close.
2008-07-16 6:35 [PATCH] IPVS: More reliable subchronization on connection close Simon Horman
@ 2008-07-16 19:49 ` Rumen Bogdanovski
2008-07-17 2:47 ` [PATCH] IPVS: More reliable synchronization " Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Rumen Bogdanovski @ 2008-07-16 19:49 UTC (permalink / raw)
To: Simon Horman; +Cc: LVS Devel, Linux Netdev List, David Miller, Joseph Mack NA3T
Would you please change the Subject to (a typo fix):
[PATCH] IPVS: More reliable synchronization on connection close.
On Wed, 2008-07-16 at 16:35 +1000, Simon Horman wrote:
> From: Rumen Bogdanovski <rumen@voicecho.com>
>
> This patch enhances the synchronization of the closing connections
> between the master and the backup director. It prevents the closed
> connections to expire with the 15 min timeout of the ESTABLISHED
> state on the backup and makes them expire as they would do on the
> master with much shorter timeouts.
>
> Cc: Joseph Mack NA3T <jmack@wm7d.net>
> Signed-off-by: Rumen G. Bogdanovski <rumen@voicecho.com>
> Acked-by: Simon Horman <horms@verge.net.au>
>
> ---
>
> Hi Dave,
>
> please consider applying this.
>
> diff -Naur net-2.6_orig/net/ipv4/ipvs/ip_vs_core.c net-2.6/net/ipv4/ipvs/ip_vs_core.c
> --- net-2.6_orig/net/ipv4/ipvs/ip_vs_core.c 2008-07-15 11:23:44.000000000 +0300
> +++ net-2.6/net/ipv4/ipvs/ip_vs_core.c 2008-07-15 11:27:31.000000000 +0300
> @@ -993,7 +993,8 @@
> == sysctl_ip_vs_sync_threshold[0])) ||
> ((cp->protocol == IPPROTO_TCP) && (cp->old_state != cp->state) &&
> ((cp->state == IP_VS_TCP_S_FIN_WAIT) ||
> - (cp->state == IP_VS_TCP_S_CLOSE)))))
> + (cp->state == IP_VS_TCP_S_CLOSE_WAIT) ||
> + (cp->state == IP_VS_TCP_S_TIME_WAIT)))))
> ip_vs_sync_conn(cp);
> cp->old_state = cp->state;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IPVS: More reliable synchronization on connection close
2008-07-16 6:35 [PATCH] IPVS: More reliable subchronization on connection close Simon Horman
2008-07-16 19:49 ` Rumen Bogdanovski
@ 2008-07-17 2:47 ` Simon Horman
2008-07-17 3:04 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2008-07-17 2:47 UTC (permalink / raw)
To: LVS Devel, Linux Netdev List
Cc: David Miller, Rumen Bogdanovski, Joseph Mack NA3T
From: Rumen Bogdanovski <rumen@voicecho.com>
This patch enhances the synchronization of the closing connections
between the master and the backup director. It prevents the closed
connections to expire with the 15 min timeout of the ESTABLISHED
state on the backup and makes them expire as they would do on the
master with much shorter timeouts.
Cc: Joseph Mack NA3T <jmack@wm7d.net>
Signed-off-by: Rumen G. Bogdanovski <rumen@voicecho.com>
Acked-by: Simon Horman <horms@verge.net.au>
---
Hi Dave,
please consider applying this.
Changes:
* Fixed typo in subject
* Previous post was encoded as quoted-printable
diff -Naur net-2.6_orig/net/ipv4/ipvs/ip_vs_core.c net-2.6/net/ipv4/ipvs/ip_vs_core.c
--- net-2.6_orig/net/ipv4/ipvs/ip_vs_core.c 2008-07-15 11:23:44.000000000 +0300
+++ net-2.6/net/ipv4/ipvs/ip_vs_core.c 2008-07-15 11:27:31.000000000 +0300
@@ -993,7 +993,8 @@
== sysctl_ip_vs_sync_threshold[0])) ||
((cp->protocol == IPPROTO_TCP) && (cp->old_state != cp->state) &&
((cp->state == IP_VS_TCP_S_FIN_WAIT) ||
- (cp->state == IP_VS_TCP_S_CLOSE)))))
+ (cp->state == IP_VS_TCP_S_CLOSE_WAIT) ||
+ (cp->state == IP_VS_TCP_S_TIME_WAIT)))))
ip_vs_sync_conn(cp);
cp->old_state = cp->state;
--
Horms
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IPVS: More reliable synchronization on connection close
2008-07-17 2:47 ` [PATCH] IPVS: More reliable synchronization " Simon Horman
@ 2008-07-17 3:04 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-07-17 3:04 UTC (permalink / raw)
To: horms; +Cc: lvs-devel, netdev, rumen, jmack
From: Simon Horman <horms@verge.net.au>
Date: Thu, 17 Jul 2008 12:47:22 +1000
> This patch enhances the synchronization of the closing connections
> between the master and the backup director. It prevents the closed
> connections to expire with the 15 min timeout of the ESTABLISHED
> state on the backup and makes them expire as they would do on the
> master with much shorter timeouts.
>
> Signed-off-by: Rumen G. Bogdanovski <rumen@voicecho.com>
> Acked-by: Simon Horman <horms@verge.net.au>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-17 3:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-16 6:35 [PATCH] IPVS: More reliable subchronization on connection close Simon Horman
2008-07-16 19:49 ` Rumen Bogdanovski
2008-07-17 2:47 ` [PATCH] IPVS: More reliable synchronization " Simon Horman
2008-07-17 3:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).