From: "Denis V. Lunev" <den@openvz.org>
To: davem@davemloft.net
Cc: yi.zhu@intel.com, reinette.chatre@intel.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
"Denis V. Lunev" <den@openvz.org>
Subject: [PATCH net-next 1/2] iwlwifi: compilation error when CONFIG_IWLWIFI_DEBUG is not set
Date: Thu, 17 Jul 2008 13:19:24 +0400 [thread overview]
Message-ID: <1216286365-11703-1-git-send-email-den@openvz.org> (raw)
CC [M] drivers/net/wireless/iwlwifi/iwl-rfkill.o
drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
The problem is that led_type_str is defined under CONFIG_IWLWIFI_DEBUG
while IWL_DEBUG is a static inline function in this case. Replace it
with macro.
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
drivers/net/wireless/iwlwifi/iwl-debug.h | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
index 5838480..d6d729e 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debug.h
+++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
@@ -68,12 +68,8 @@ void iwl_dbgfs_unregister(struct iwl_priv *priv);
#endif
#else
-static inline void IWL_DEBUG(int level, const char *fmt, ...)
-{
-}
-static inline void IWL_DEBUG_LIMIT(int level, const char *fmt, ...)
-{
-}
+#define IWL_DEBUG(level, fmt, args...)
+#define IWL_DEBUG_LIMIT(level, fmt, args...)
#endif /* CONFIG_IWLWIFI_DEBUG */
--
1.5.4.5
next reply other threads:[~2008-07-17 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 9:19 Denis V. Lunev [this message]
2008-07-17 11:05 ` [PATCH net-next 1/2] iwlwifi: compilation error when CONFIG_IWLWIFI_DEBUG is not set Tomas Winkler
[not found] ` <1216286365-11703-1-git-send-email-den-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-07-17 9:19 ` [PATCH net-next 2/2] iwlwifi: small compile warnings without CONFIG_IWLWIFI_DEBUG Denis V. Lunev
2008-07-17 11:08 ` Tomas Winkler
[not found] ` <1ba2fa240807170408w13837d67hcfd1be50fdb07738-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-17 11:26 ` Denis V. Lunev
[not found] ` <1ba2fa240807170437j12547b26l803551b61a805f8d@mail.gmail.com>
2008-07-17 15:05 ` Denis V. Lunev
[not found] ` <1216307106.7034.15.camel-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
2008-07-17 15:26 ` Tomas Winkler
2008-07-18 6:56 ` [PATCH net-next 2/2][v2] " Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216286365-11703-1-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).