From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH 2/2[ Traffic control cgroups subsystem
Date: Thu, 24 Jul 2008 23:02:17 -0400
Message-ID: <1216954937.22487.1.camel@localhost.localdomain>
References: <Pine.LNX.4.64.0807241635460.30437@ranjit.corp.google.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	lizf@cn.fujitsu.com, menage@google.com, kaber@trash.net,
	akpm@linux-foundation.org
To: Ranjit Manomohan <ranjitm@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from homer.mvista.com ([63.81.120.158]:7918 "EHLO
	gateway-1237.mvista.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org
	with ESMTP id S1755458AbYGYDDo (ORCPT
	<rfc822;netdev@vger.kernel.org>); Thu, 24 Jul 2008 23:03:44 -0400
In-Reply-To: <Pine.LNX.4.64.0807241635460.30437@ranjit.corp.google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 2008-07-24 at 16:37 -0700, Ranjit Manomohan wrote:


> +/* Delete one filter entry */
> +static int cgroup_delete(struct tcf_proto *tp, unsigned long arg)
> +{
> +	struct cgroup_head *head = (struct cgroup_head *) tp->root;
> +	struct cgroup_filter *t, *f = (struct cgroup_filter *) arg;
> +
> +	list_for_each_entry(t, &head->flist, link)
> +		if (t == f) {
> +			tcf_tree_lock(tp);
> +			list_del(&t->link);

Doesn't the above need to be a "_safe" list operation since your
deleting the element?

Daniel