From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nate Case Subject: Re: [PATCH / RFC] net: don't grab a mutex within a timer context in gianfar Date: Fri, 25 Jul 2008 09:16:00 -0500 Message-ID: <1216995360.7559.1022.camel@localhost.localdomain> References: <20080718121008.GA28871@Chamillionaire.breakpoint.cc> <1216681028.7559.993.camel@localhost.localdomain> <20080722205911.GA29840@Chamillionaire.breakpoint.cc> <20080723200337.GA5122@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, Vitaly Bordug , Li Yang , Jeff Garzik To: Sebastian Siewior Return-path: In-Reply-To: <20080723200337.GA5122@Chamillionaire.breakpoint.cc> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org List-Id: netdev.vger.kernel.org On Wed, 2008-07-23 at 22:03 +0200, Sebastian Siewior wrote: > I moved it into a workqueue, this is what tg3 does. > I would convert the other three drivers unless $dude suggests a better > method or somebody else takes care.... > > drivers/net/gianfar.c | 22 ++++++++++++++++++---- > drivers/net/gianfar.h | 2 ++ > 2 files changed, 20 insertions(+), 4 deletions(-) This looks good to me. -- Nate Case