netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired
Date: Sat, 26 Jul 2008 20:37:32 +0400	[thread overview]
Message-ID: <1217090252.6549.4.camel@iris.sw.ru> (raw)
In-Reply-To: <Pine.LNX.4.64.0807261345400.6643@blonde.site>

Acked-by: Denis V. Lunev <den@openvz.org>

Thanks for founding this issue...

On Sat, 2008-07-26 at 13:48 +0100, Hugh Dickins wrote:
> Running recent kernels, and using a particular vpn gateway, I've been
> having to edit my mails down to get them accepted by the smtp server.
> 
> Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
> netns: place rt_genid into struct net.  The conversion from a != test
> to rt_is_expired() put one negative too many: and now my mail works.
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Ingo was having strange distcc problems, might this help him too?
> 
>  net/ipv4/route.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 2.6.26-git/net/ipv4/route.c	2008-07-26 12:31:50.000000000 +0100
> +++ linux/net/ipv4/route.c	2008-07-26 13:10:04.000000000 +0100
> @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct 
>  				    rth->fl.iif != 0 ||
>  				    dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
>  				    !net_eq(dev_net(rth->u.dst.dev), net) ||
> -				    !rt_is_expired(rth))
> +				    rt_is_expired(rth))
>  					continue;
>  
>  				if (new_mtu < 68 || new_mtu >= old_mtu) {


  reply	other threads:[~2008-07-26 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-26 12:48 [PATCH] netns: fix ip_rt_frag_needed rt_is_expired Hugh Dickins
2008-07-26 16:37 ` Denis V. Lunev [this message]
2008-07-26 19:10   ` Denis V. Lunev
2008-07-26 19:26     ` Hugh Dickins
2008-07-27  0:51   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217090252.6549.4.camel@iris.sw.ru \
    --to=den@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).