Re: [PATCH] typhoon: use request_firmware

David Dillow
2008-07-28T12:36:28Z

On Mon, 2008-07-28 at 08:46 +0530, Jaswinder Singh wrote:
> On Sun, 2008-07-27 at 21:43 -0400, David Dillow wrote:
> > It is not quite this simple. By not loading the firmware on device
> > probe, you have opened the door to a broken resume, and the driver will
> > now try to sleep in an atomic context, when typhoon_tx_timeout() is
> > called at the very least.
> >
>
> I just added the request_firmware support and
> replaced ﻿typhoon_firmware_image with ﻿fw->data.
> I do not think this will make any difference in rest of driver.

Please re-read what I said -- you broke error handling and potentially
resume. Previously, the firmware was available without a sleeping call
to user space to get it. Now, it is not. You cannot sleep in
typhoon_tx_timeout(), and trying to get a firmware image in resume is
going to be a problem if your file system is NFS mounted over the NIC
you're trying to resume.