From: David Dillow <dave@thedillows.org>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
becker@scyld.com, davidpmclean@yahoo.com,
Jeff Garzik <jeff@garzik.org>, netdev <netdev@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] typhoon: use request_firmware
Date: Mon, 28 Jul 2008 08:36:25 -0400 [thread overview]
Message-ID: <1217248585.22789.58.camel@obelisk.thedillows.org> (raw)
In-Reply-To: <1217215009.2970.7.camel@jaswinder.satnam>
On Mon, 2008-07-28 at 08:46 +0530, Jaswinder Singh wrote:
> On Sun, 2008-07-27 at 21:43 -0400, David Dillow wrote:
> > It is not quite this simple. By not loading the firmware on device
> > probe, you have opened the door to a broken resume, and the driver will
> > now try to sleep in an atomic context, when typhoon_tx_timeout() is
> > called at the very least.
> >
>
> I just added the request_firmware support and
> replaced typhoon_firmware_image with fw->data.
> I do not think this will make any difference in rest of driver.
Please re-read what I said -- you broke error handling and potentially
resume. Previously, the firmware was available without a sleeping call
to user space to get it. Now, it is not. You cannot sleep in
typhoon_tx_timeout(), and trying to get a firmware image in resume is
going to be a problem if your file system is NFS mounted over the NIC
you're trying to resume.
http://marc.info/?l=linux-kernel&m=121608383506190&w=2
http://marc.info/?l=linux-kernel&m=121608255704704&w=2
next prev parent reply other threads:[~2008-07-28 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 14:50 [PATCH] typhoon: use request_firmware Jaswinder Singh
2008-07-28 1:43 ` David Dillow
2008-07-28 3:16 ` Jaswinder Singh
2008-07-28 12:36 ` David Dillow [this message]
2008-07-28 13:54 ` Jaswinder Singh
2008-07-29 1:38 ` David Dillow
2008-07-29 3:57 ` David Dillow
2008-07-29 16:09 ` Jaswinder Singh
2008-07-30 5:25 ` David Dillow
2008-07-30 6:44 ` Jaswinder Singh
2008-07-31 3:37 ` David Dillow
2008-07-31 7:42 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217248585.22789.58.camel@obelisk.thedillows.org \
--to=dave@thedillows.org \
--cc=becker@scyld.com \
--cc=davidpmclean@yahoo.com \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox