netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ron Mercer <ron.mercer@qlogic.com>
To: jeff@garzik.org
Cc: netdev@vger.kernel.org, Ron Mercer <ron.mercer@qlogic.com>
Subject: [PATCH 1/5] qla3xxx: fix: Remove unused set_multicast function.
Date: Thu, 31 Jul 2008 13:46:04 -0700	[thread overview]
Message-ID: <12175371683630-git-send-email-ron.mercer@qlogic.com> (raw)
In-Reply-To: <20080731204514.GA5457@susedev.qlogic.org>

This device is one side of a two-function adapter (NIC and iSCSI).
Promiscuous mode setting/clearing is not allowed from the NIC side.

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
 drivers/net/qla3xxx.c |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index bccee68..7ddb2b0 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -3730,14 +3730,6 @@ static int ql3xxx_open(struct net_device *ndev)
 	return (ql_adapter_up(qdev));
 }
 
-static void ql3xxx_set_multicast_list(struct net_device *ndev)
-{
-	/*
-	 * We are manually parsing the list in the net_device structure.
-	 */
-	return;
-}
-
 static int ql3xxx_set_mac_address(struct net_device *ndev, void *p)
 {
 	struct ql3_adapter *qdev = (struct ql3_adapter *)netdev_priv(ndev);
@@ -4007,7 +3999,11 @@ static int __devinit ql3xxx_probe(struct pci_dev *pdev,
 	ndev->open = ql3xxx_open;
 	ndev->hard_start_xmit = ql3xxx_send;
 	ndev->stop = ql3xxx_close;
-	ndev->set_multicast_list = ql3xxx_set_multicast_list;
+	/* ndev->set_multicast_list
+	 * This device is one side of a two-function adapter
+	 * (NIC and iSCSI).  Promiscuous mode setting/clearing is
+	 * not allowed from the NIC side.
+	 */
 	SET_ETHTOOL_OPS(ndev, &ql3xxx_ethtool_ops);
 	ndev->set_mac_address = ql3xxx_set_mac_address;
 	ndev->tx_timeout = ql3xxx_tx_timeout;
-- 
1.5.0.rc4.16.g9e258


  reply	other threads:[~2008-07-31 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31 20:45 [patch 0/5] qla3xxx: driver cleanup Ron Mercer
2008-07-31 20:46 ` Ron Mercer [this message]
2008-08-07  6:12   ` [PATCH 1/5] qla3xxx: fix: Remove unused set_multicast function Jeff Garzik
2008-07-31 20:46 ` [PATCH 2/5] qla3xxx: fix: Fix IFF_MULTICAST setting Ron Mercer
2008-07-31 20:46 ` [PATCH 3/5] qla3xxx: cleanup: Remove some unused defined constants in the header file Ron Mercer
2008-07-31 20:46 ` [PATCH 4/5] qla3xxx: cleanup: Remove some unused structure definitions and structure elements Ron Mercer
2008-07-31 20:46 ` [PATCH 5/5] qla3xxx: driver version change Ron Mercer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12175371683630-git-send-email-ron.mercer@qlogic.com \
    --to=ron.mercer@qlogic.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).