From: Marcel Holtmann <marcel@holtmann.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless-2.6 2008-08-04
Date: Tue, 05 Aug 2008 00:37:06 +0200 [thread overview]
Message-ID: <1217889426.7819.26.camel@californication> (raw)
In-Reply-To: <20080804215439.GA9658@tuxdriver.com>
Hi John,
> > > > > Luis R. Rodriguez (4):
> > > > > list.h: Add list_splice_tail() and list_splice_tail_init()
> > > > > list.h: add list_cut_position()
> > > >
> > > > have these two changes got reviewed on LKML? I don't see any ACKs for it
> > > > in the commit message.
> > >
> > > Hmmm...no. I thought the original patches had been copied to
> > > linux-kernel, but it looks like that is not the case.
> > >
> > > The original patches are archived here:
> > >
> > > http://marc.info/?l=linux-wireless&m=121783421908441&w=2
> > >
> > > http://marc.info/?l=linux-wireless&m=121783422008445&w=2
> > >
> > > What problems do you see with them?
> >
> > I don't see a problem with these patches, but they should at least be
> > reviewed on LKML once. Changes to core kernel infrastructure should not
> > be merged silently via subsystem trees without any kind of ACKs.
>
> Yes, fine. That wasn't my intent. :-) The patches were originally
> posted about two weeks ago, too bad that didn't actually go to
> linux-kernel. :-(
just post them to LKML (or let Luis do it) so they get reviewed. I
really don't see an issue with them, but that is only me.
Regards
Marcel
next prev parent reply other threads:[~2008-08-04 22:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 19:37 pull request: wireless-2.6 2008-08-04 John W. Linville
2008-08-04 20:38 ` Marcel Holtmann
2008-08-04 20:45 ` John W. Linville
2008-08-04 21:42 ` Marcel Holtmann
2008-08-04 21:54 ` John W. Linville
2008-08-04 22:37 ` Marcel Holtmann [this message]
2008-08-04 22:45 ` Luis R. Rodriguez
2008-08-04 23:38 ` Justin Mattock
2008-08-04 21:58 ` David Miller
2008-08-04 22:01 ` David Miller
[not found] ` <20080804.150147.78586437.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-05 2:17 ` John W. Linville
2008-08-05 3:04 ` Pavel Roskin
2008-08-05 8:28 ` David Miller
[not found] ` <20080805.012814.215633850.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-05 13:28 ` Stephen Rothwell
2008-08-05 14:05 ` John W. Linville
2008-08-05 15:30 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217889426.7819.26.camel@californication \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).