From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: pull request: wireless-2.6 2008-08-04 Date: Tue, 05 Aug 2008 00:37:06 +0200 Message-ID: <1217889426.7819.26.camel@californication> References: <20080804193753.GA30345@tuxdriver.com> <1217882288.7819.19.camel@californication> <20080804204558.GA5866@tuxdriver.com> <1217886123.7819.23.camel@californication> <20080804215439.GA9658@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "John W. Linville" Return-path: Received: from senator.holtmann.net ([87.106.208.187]:52020 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbYHDWdO (ORCPT ); Mon, 4 Aug 2008 18:33:14 -0400 In-Reply-To: <20080804215439.GA9658@tuxdriver.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi John, > > > > > Luis R. Rodriguez (4): > > > > > list.h: Add list_splice_tail() and list_splice_tail_init() > > > > > list.h: add list_cut_position() > > > > > > > > have these two changes got reviewed on LKML? I don't see any ACKs for it > > > > in the commit message. > > > > > > Hmmm...no. I thought the original patches had been copied to > > > linux-kernel, but it looks like that is not the case. > > > > > > The original patches are archived here: > > > > > > http://marc.info/?l=linux-wireless&m=121783421908441&w=2 > > > > > > http://marc.info/?l=linux-wireless&m=121783422008445&w=2 > > > > > > What problems do you see with them? > > > > I don't see a problem with these patches, but they should at least be > > reviewed on LKML once. Changes to core kernel infrastructure should not > > be merged silently via subsystem trees without any kind of ACKs. > > Yes, fine. That wasn't my intent. :-) The patches were originally > posted about two weeks ago, too bad that didn't actually go to > linux-kernel. :-( just post them to LKML (or let Luis do it) so they get reviewed. I really don't see an issue with them, but that is only me. Regards Marcel