From: jamal <hadi@cyberus.ca>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: iproute2/m_ipt fix, opts was not set properly
Date: Wed, 06 Aug 2008 06:52:25 -0400 [thread overview]
Message-ID: <1218019945.4755.36.camel@localhost> (raw)
In-Reply-To: <1218019350.4755.30.camel@localhost>
On Wed, 2008-06-08 at 06:42 -0400, jamal wrote:
> Sorry Denys, unless my memory has lost the C scoping rules, i dont think
> the shadowing you describe above is accurate. Let me take a closer look.
Grrr. I see the bug; until you tested with batching, it probably hasnt
mattered.
I still dont see how your patch fixes it. But heres a fix that I think
will work:
1. change free_opts to be:
static void free_opts(struct option **opts)
{
if (*opts != original_opts) {
free(*opts);
*opts = original_opts;
}
}
2. Change invocations of free_opts to be:
free_opts(&opts);
cheers,
jamal
next prev parent reply other threads:[~2008-08-06 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 19:24 iproute2/m_ipt fix, opts was not set properly Denys Fedoryshchenko
2008-08-06 9:52 ` jamal
2008-08-06 10:06 ` Denys Fedoryshchenko
2008-08-06 10:42 ` jamal
2008-08-06 10:52 ` jamal [this message]
2008-08-06 11:02 ` Denys Fedoryshchenko
2008-08-06 11:18 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218019945.4755.36.camel@localhost \
--to=hadi@cyberus.ca \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).