From: jamal <hadi@cyberus.ca>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: few more fixes for iproute2/m_ipt
Date: Wed, 06 Aug 2008 07:04:46 -0400 [thread overview]
Message-ID: <1218020686.4755.42.camel@localhost> (raw)
In-Reply-To: <200808061321.19560.denys@visp.net.lb>
On Wed, 2008-06-08 at 13:21 +0300, Denys Fedoryshchenko wrote:
> #1 is validated 100%, because i was not able to run tc in batch mode for my
> tasks(2nd or 3rd ipt rule will crash), till i implement those patches. The
> batch i gave is short version, full version have around 11k lines. But it
> crashes usually max on 2rd or 3nd ipt.
Ok, thanks - let me take a closer look.
Actually i dont doubt that when you batch the optind maybe shaky - I am
more worried about other working scenarios that may have depended on it.
I will still say put #2 and #3 in separate patch.
> Well, i can fix what i can sniff&smell in my daily job, and especially if i
> hit a wall because of some code :-) For me it is difficult to inspect the
> code, since i am very weak in C, but i will try.
I understand it could be frustrating sometimes but given
your situation you are doing fantastic work. It is highly appreciated.
cheers,
jamal
next prev parent reply other threads:[~2008-08-06 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 21:42 few more fixes for iproute2/m_ipt Denys Fedoryshchenko
2008-08-06 10:04 ` jamal
2008-08-06 10:21 ` Denys Fedoryshchenko
2008-08-06 11:04 ` jamal [this message]
2008-08-06 11:26 ` Denys Fedoryshchenko
2008-08-06 12:46 ` jamal
2008-08-06 12:50 ` Denys Fedoryshchenko
2008-08-06 12:55 ` jamal
2008-08-06 12:56 ` Denys Fedoryshchenko
2008-08-06 12:59 ` Denys Fedoryshchenko
2008-08-06 13:17 ` jamal
2009-01-07 3:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218020686.4755.42.camel@localhost \
--to=hadi@cyberus.ca \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).