From: "Denis V. Lunev" <den@parallels.com>
To: Vlad Yasevich <vladislav.yasevich@hp.com>
Cc: Brian Haley <brian.haley@hp.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, containers <containers@lists.osdl.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr()
Date: Fri, 15 Aug 2008 00:18:44 +0400 [thread overview]
Message-ID: <1218745124.16589.73.camel@iris.sw.ru> (raw)
In-Reply-To: <48A48FC9.4020805@hp.com>
On Thu, 2008-08-14 at 16:04 -0400, Vlad Yasevich wrote:
> Hi Brian
>
> Brian Haley wrote:
> > ---
> >
> > diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> > index 483a01d..e0945d4 100644
> > --- a/net/sctp/ipv6.c
> > +++ b/net/sctp/ipv6.c
> > @@ -319,7 +319,8 @@ static void sctp_v6_get_saddr(struct sctp_sock *sk,
> > __func__, asoc, dst, NIP6(daddr->v6.sin6_addr));
> >
> > if (!asoc) {
> > - ipv6_dev_get_saddr(dst ? ip6_dst_idev(dst)->dev : NULL,
> > + ipv6_dev_get_saddr(NULL,
> > + dst ? ip6_dst_idev(dst)->dev : NULL,
> > &daddr->v6.sin6_addr,
> > inet6_sk(&sk->inet.sk)->srcprefs,
> > &saddr->v6.sin6_addr);
>
>
> I think this needs to use sock_net(sctp_opt2s(sk)) instead of NULL.
this looks safe to me
next prev parent reply other threads:[~2008-08-14 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 19:27 [PATCH 2/2] netns: Add network namespace argument in rt6_fill_node() and ipv6_dev_get_saddr() Brian Haley
2008-08-14 20:04 ` Vlad Yasevich
2008-08-14 20:16 ` Brian Haley
2008-08-14 20:29 ` Vlad Yasevich
2008-08-14 20:18 ` Denis V. Lunev [this message]
2008-08-16 22:47 ` Daniel Lezcano
2008-08-17 22:35 ` David Miller
[not found] ` <20080817.153526.109132408.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-18 7:21 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218745124.16589.73.camel@iris.sw.ru \
--to=den@parallels.com \
--cc=brian.haley@hp.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).