netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Jeff Garzik <jgarzik@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
	Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2
Date: Sat, 16 Aug 2008 23:25:33 -0700	[thread overview]
Message-ID: <1218954333-12819-1-git-send-email-yhlu.kernel@gmail.com> (raw)

after

| commit f735a2a1a4f2a0f5cd823ce323e82675990469e2
| Author: Tobias Diedrich <ranma+kernel@tdiedrich.de>
| Date:   Sun May 18 15:02:37 2008 +0200
|
|    [netdrvr] forcedeth: setup wake-on-lan before shutting down
|
|    When hibernating in 'shutdown' mode, after saving the image the suspend hook
|    is not called again.
|    However, if the device is in promiscous mode, wake-on-lan will not work.
|    This adds a shutdown hook to setup wake-on-lan before the final shutdown.
|
|    Signed-off-by: Tobias Diedrich <ranma+kernel@tdiedrich.de>
|    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

my servers with nvidia mcp55 nic doesn't work with msi in second kernel by kexec

after remove pci_set_power_state(, PCI_D3hot) that nic/msi will work again.

check with e1000 is using pci_choose_state in _shutdown.

So change that pci_choose_state(pdev, ...), and it works.

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

---
 drivers/net/forcedeth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/net/forcedeth.c
===================================================================
--- linux-2.6.orig/drivers/net/forcedeth.c
+++ linux-2.6/drivers/net/forcedeth.c
@@ -5988,7 +5988,7 @@ static void nv_shutdown(struct pci_dev *
 	pci_enable_wake(pdev, PCI_D3hot, np->wolenabled);
 	pci_enable_wake(pdev, PCI_D3cold, np->wolenabled);
 	pci_disable_device(pdev);
-	pci_set_power_state(pdev, PCI_D3hot);
+	pci_set_power_state(pdev, pci_choose_state(pdev, PMSG_SUSPEND));
 }
 #else
 #define nv_suspend NULL

             reply	other threads:[~2008-08-17  6:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17  6:25 Yinghai Lu [this message]
2008-08-17 13:02 ` [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2 Rafael J. Wysocki
2008-08-17 16:55   ` Rafael J. Wysocki
2008-08-17 19:16     ` Yinghai Lu
2008-08-17 19:29       ` Rafael J. Wysocki
2008-08-17 19:34         ` Rafael J. Wysocki
2008-08-17 20:58           ` Yinghai Lu
2008-08-17 21:47             ` Rafael J. Wysocki
2008-08-18 10:22               ` Rafael J. Wysocki
2008-08-18 21:50                 ` Yinghai Lu
2008-08-18 22:08                   ` Rafael J. Wysocki
2008-08-18 22:36                     ` Yinghai Lu
2008-08-19 18:45                       ` [PATCH] forcedeth: Fix kexec regression Rafael J. Wysocki
2008-08-19 20:37                         ` Andrew Morton
2008-08-19 20:49                           ` Rafael J. Wysocki
2008-08-20  7:01                         ` Eric W. Biederman
2008-08-20 13:12                           ` Rafael J. Wysocki
2008-08-18 22:37                     ` [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2 Yinghai Lu
2008-08-18 22:42                     ` Simon Arlott
2008-08-19 17:58                       ` Rafael J. Wysocki
2008-08-19 18:33                         ` Simon Arlott
2008-08-19 21:09                           ` Rafael J. Wysocki
2008-08-30 19:39                             ` Simon Arlott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218954333-12819-1-git-send-email-yhlu.kernel@gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).