From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2 Date: Sat, 16 Aug 2008 23:25:33 -0700 Message-ID: <1218954333-12819-1-git-send-email-yhlu.kernel@gmail.com> Cc: linux-kernel@vger.kernel.org, netdev , Yinghai Lu To: Jeff Garzik , Ingo Molnar , "Eric W. Biederman" , Andrew Morton Return-path: Received: from wa-out-1112.google.com ([209.85.146.179]:43835 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbYHQG0W (ORCPT ); Sun, 17 Aug 2008 02:26:22 -0400 Received: by wa-out-1112.google.com with SMTP id j37so995105waf.23 for ; Sat, 16 Aug 2008 23:26:21 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: after | commit f735a2a1a4f2a0f5cd823ce323e82675990469e2 | Author: Tobias Diedrich | Date: Sun May 18 15:02:37 2008 +0200 | | [netdrvr] forcedeth: setup wake-on-lan before shutting down | | When hibernating in 'shutdown' mode, after saving the image the suspend hook | is not called again. | However, if the device is in promiscous mode, wake-on-lan will not work. | This adds a shutdown hook to setup wake-on-lan before the final shutdown. | | Signed-off-by: Tobias Diedrich | Signed-off-by: Jeff Garzik my servers with nvidia mcp55 nic doesn't work with msi in second kernel by kexec after remove pci_set_power_state(, PCI_D3hot) that nic/msi will work again. check with e1000 is using pci_choose_state in _shutdown. So change that pci_choose_state(pdev, ...), and it works. Signed-off-by: Yinghai Lu --- drivers/net/forcedeth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/net/forcedeth.c =================================================================== --- linux-2.6.orig/drivers/net/forcedeth.c +++ linux-2.6/drivers/net/forcedeth.c @@ -5988,7 +5988,7 @@ static void nv_shutdown(struct pci_dev * pci_enable_wake(pdev, PCI_D3hot, np->wolenabled); pci_enable_wake(pdev, PCI_D3cold, np->wolenabled); pci_disable_device(pdev); - pci_set_power_state(pdev, PCI_D3hot); + pci_set_power_state(pdev, pci_choose_state(pdev, PMSG_SUSPEND)); } #else #define nv_suspend NULL