From: Artem Bityutskiy <dedekind@infradead.org>
To: Hirofumi Nakagawa <hnakagawa@miraclelinux.com>
Cc: yoshfuji@linux-ipv6.org, christof.schmitt@de.ibm.com,
netdev@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] Remove duplicated unlikely() in IS_ERR()
Date: Tue, 19 Aug 2008 17:57:38 +0300 [thread overview]
Message-ID: <1219157858.18027.44.camel@sauron> (raw)
In-Reply-To: <1219125321.18027.9.camel@sauron>
On Tue, 2008-08-19 at 08:55 +0300, Artem Bityutskiy wrote:
> On Fri, 2008-08-15 at 16:16 +0900, Hirofumi Nakagawa wrote:
> > Hi
> > Some drivers have duplicated unlikely() macros.
> > IS_ERR() already has unlikely() in itself.
> > This patch cleans up such pointless codes although there is no real
> > effect on the kernel's behaviour.
> >
> > Thanks,
> > Hirofumi Nakagawa
> >
> > Signed-off-by: Hirofumi Nakagawa <hnakagawa@miraclelinux.com>
> > ---
>
> Hmm, after thinking a bit I am not sure this is the right way to go.
> Indeed, we try to avoid likly()/unlikely(), unless this is really
> hot-path. Some kernel developers even think these hints should never
> be used. So I'd say, the right thing would bo to remove unlikely()
> from IS_ERR() macro instead.
OK, after some googling I tend to thing having unlikely() in IS_ERR() is
OK, so I take your patch. Thanks.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2008-08-19 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 7:16 [PATCH] Remove duplicated unlikely() in IS_ERR() Hirofumi Nakagawa
2008-08-15 12:16 ` Artem Bityutskiy
2008-08-18 15:21 ` Christof Schmitt
2008-08-18 23:10 ` Mike Frysinger
2008-08-19 5:55 ` Artem Bityutskiy
2008-08-19 14:57 ` Artem Bityutskiy [this message]
2008-08-21 12:39 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219157858.18027.44.camel@sauron \
--to=dedekind@infradead.org \
--cc=christof.schmitt@de.ibm.com \
--cc=hnakagawa@miraclelinux.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).