Re: [UPDATED] [NET-NEXT PATCH 2/2] pkt_action: add new action skbedit

Jarek Poplawski
2008-09-02T12:27:33Z

On 30-08-2008 09:24, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This new action will have the ability to change the priority and/or
> queue_mapping fields on an sk_buff.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Two cosmetic suggestions:

Probably: include/linux/tc_act/Kbuild should be updated too.

> include/linux/tc_act/tc_skbedit.h | 23 ++++
> include/net/tc_act/tc_skbedit.h | 15 +++
> net/sched/Kconfig | 11 ++
> net/sched/Makefile | 1
> net/sched/act_skbedit.c | 200 +++++++++++++++++++++++++++++++++++++
...
> diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c
> new file mode 100644
> index 0000000..0bc4616
> --- /dev/null
> +++ b/net/sched/act_skbedit.c
...
> +#include <net/pkt_sched.h>
> +
> +#define TCA_ACT_SKBEDIT 11

Doesn't matter, but most of others (except act_simple) keep this TCA_
in include/linux/tc_act/tc_xyz.h.

Otherwise it looks OK to me.

Jarek P.