From: Mirko Lindner <mlindner@syskonnect.de>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Ralph Roesler <rroesler@syskonnect.de>,
netdev@oss.sgi.com
Subject: Re: [RFT] simplify skge /proc interface.
Date: Fri, 5 Sep 2003 09:27:11 +0000 (UTC)
Date: 05 Sep 2008 11:26:04 +0200 [thread overview]
Message-ID: <1220606764.18887.129.camel@mlindner-lin> (raw)
In-Reply-To: <20030904160658.5ae22c0d.shemminger@osdl.org>
Thank you for the submission,
the latest driver version 6.17 (still by Linus) has a lot of
proc-changes. I´ll insert the remaining changes into our tree and make a
new release next week.
Cheers,
Mirko
On Fri, 2003-09-05 at 01:06, Stephen Hemminger wrote:
> This patch is against 2.6.0-test4 and simplifys the /proc interface for
> the skge driver.
>
> * Use seq_file single_open interface to avoid possible buffer over
> run and formatting issues.
> * Put pointer to device in the proc dir private data to avoid having
> to search through devices to find the info.
> * Use %lld rather than special formatting code
> * use proc_mkdir
> * Don't die if proc fs is not configured or creating entries fails.
>
> New code is written in kernel style.
>
> Builds and loads but don't have real hardware. Could someone
> please test this with a real board?
>
> Somewhere in this 8K line driver is a 1000 line driver waiting to get out...
>
next prev parent reply other threads:[~2003-09-05 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-04 23:06 [RFT] simplify skge /proc interface Stephen Hemminger
2003-09-05 9:27 ` Mirko Lindner [this message]
2003-09-26 18:17 ` [PATCH] (1/3) sk98lin -- build on smp fix Stephen Hemminger
2003-09-27 9:57 ` Jeff Garzik
2003-09-26 18:17 ` [PATCH] (2/3) skge -- handle proc_fs errors Stephen Hemminger
2003-09-26 18:17 ` [PATCH] (3/3) sk98lin -- use seq_file for /proc Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220606764.18887.129.camel@mlindner-lin \
--to=mlindner@syskonnect.de \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=rroesler@syskonnect.de \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).