From: Alexey Dobriyan <adobriyan@gmail.com>
To: kaber@trash.net
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: [PATCH 09/33] netns ct: per-netns /proc/net/nf_conntrack, /proc/net/stat/nf_conntrack
Date: Mon, 8 Sep 2008 07:02:46 +0400 [thread overview]
Message-ID: <1220842990-30500-9-git-send-email-adobriyan@gmail.com> (raw)
In-Reply-To: <48C01046.2070704@trash.net>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c
index 5456e4b..02eaf87 100644
--- a/net/netfilter/nf_conntrack_standalone.c
+++ b/net/netfilter/nf_conntrack_standalone.c
@@ -40,18 +40,20 @@ print_tuple(struct seq_file *s, const struct nf_conntrack_tuple *tuple,
EXPORT_SYMBOL_GPL(print_tuple);
struct ct_iter_state {
+ struct seq_net_private p;
unsigned int bucket;
};
static struct hlist_node *ct_get_first(struct seq_file *seq)
{
+ struct net *net = seq_file_net(seq);
struct ct_iter_state *st = seq->private;
struct hlist_node *n;
for (st->bucket = 0;
st->bucket < nf_conntrack_htable_size;
st->bucket++) {
- n = rcu_dereference(init_net.ct.hash[st->bucket].first);
+ n = rcu_dereference(net->ct.hash[st->bucket].first);
if (n)
return n;
}
@@ -61,13 +63,14 @@ static struct hlist_node *ct_get_first(struct seq_file *seq)
static struct hlist_node *ct_get_next(struct seq_file *seq,
struct hlist_node *head)
{
+ struct net *net = seq_file_net(seq);
struct ct_iter_state *st = seq->private;
head = rcu_dereference(head->next);
while (head == NULL) {
if (++st->bucket >= nf_conntrack_htable_size)
return NULL;
- head = rcu_dereference(init_net.ct.hash[st->bucket].first);
+ head = rcu_dereference(net->ct.hash[st->bucket].first);
}
return head;
}
@@ -177,7 +180,7 @@ static const struct seq_operations ct_seq_ops = {
static int ct_open(struct inode *inode, struct file *file)
{
- return seq_open_private(file, &ct_seq_ops,
+ return seq_open_net(inode, file, &ct_seq_ops,
sizeof(struct ct_iter_state));
}
@@ -186,7 +189,7 @@ static const struct file_operations ct_file_ops = {
.open = ct_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release_private,
+ .release = seq_release_net,
};
static void *ct_cpu_seq_start(struct seq_file *seq, loff_t *pos)
@@ -277,38 +280,38 @@ static const struct file_operations ct_cpu_seq_fops = {
.release = seq_release,
};
-static int nf_conntrack_standalone_init_proc(void)
+static int nf_conntrack_standalone_init_proc(struct net *net)
{
struct proc_dir_entry *pde;
- pde = proc_net_fops_create(&init_net, "nf_conntrack", 0440, &ct_file_ops);
+ pde = proc_net_fops_create(net, "nf_conntrack", 0440, &ct_file_ops);
if (!pde)
goto out_nf_conntrack;
- pde = proc_create("nf_conntrack", S_IRUGO, init_net.proc_net_stat,
+ pde = proc_create("nf_conntrack", S_IRUGO, net->proc_net_stat,
&ct_cpu_seq_fops);
if (!pde)
goto out_stat_nf_conntrack;
return 0;
out_stat_nf_conntrack:
- proc_net_remove(&init_net, "nf_conntrack");
+ proc_net_remove(net, "nf_conntrack");
out_nf_conntrack:
return -ENOMEM;
}
-static void nf_conntrack_standalone_fini_proc(void)
+static void nf_conntrack_standalone_fini_proc(struct net *net)
{
- remove_proc_entry("nf_conntrack", init_net.proc_net_stat);
- proc_net_remove(&init_net, "nf_conntrack");
+ remove_proc_entry("nf_conntrack", net->proc_net_stat);
+ proc_net_remove(net, "nf_conntrack");
}
#else
-static int nf_conntrack_standalone_init_proc(void)
+static int nf_conntrack_standalone_init_proc(struct net *net)
{
return 0;
}
-static void nf_conntrack_standalone_fini_proc(void)
+static void nf_conntrack_standalone_fini_proc(struct net *net)
{
}
#endif /* CONFIG_PROC_FS */
@@ -442,11 +445,25 @@ static void nf_conntrack_standalone_fini_sysctl(void)
static int nf_conntrack_net_init(struct net *net)
{
- return nf_conntrack_init(net);
+ int ret;
+
+ ret = nf_conntrack_init(net);
+ if (ret < 0)
+ goto out_init;
+ ret = nf_conntrack_standalone_init_proc(net);
+ if (ret < 0)
+ goto out_proc;
+ return 0;
+
+out_proc:
+ nf_conntrack_cleanup(net);
+out_init:
+ return ret;
}
static void nf_conntrack_net_exit(struct net *net)
{
+ nf_conntrack_standalone_fini_proc(net);
nf_conntrack_cleanup(net);
}
@@ -462,17 +479,12 @@ static int __init nf_conntrack_standalone_init(void)
ret = register_pernet_subsys(&nf_conntrack_net_ops);
if (ret < 0)
goto out;
- ret = nf_conntrack_standalone_init_proc();
- if (ret < 0)
- goto out_proc;
ret = nf_conntrack_standalone_init_sysctl();
if (ret < 0)
goto out_sysctl;
return 0;
out_sysctl:
- nf_conntrack_standalone_fini_proc();
-out_proc:
unregister_pernet_subsys(&nf_conntrack_net_ops);
out:
return ret;
@@ -481,7 +493,6 @@ out:
static void __exit nf_conntrack_standalone_fini(void)
{
nf_conntrack_standalone_fini_sysctl();
- nf_conntrack_standalone_fini_proc();
unregister_pernet_subsys(&nf_conntrack_net_ops);
}
next prev parent reply other threads:[~2008-09-08 3:01 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 22:00 [PATCH 10/38] netns ct: per-netns expectations adobriyan
2008-09-04 16:43 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 01/33] nf_conntrack_sip: de-static helper pointers Alexey Dobriyan
2008-09-08 3:02 ` [PATCH 02/33] nf_conntrack_gre: more locking around keymap list Alexey Dobriyan
2008-09-08 3:02 ` [PATCH 03/33] nf_conntrack_gre: nf_ct_gre_keymap_flush() fixlet Alexey Dobriyan
2008-09-09 5:39 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 04/33] Fix {ip,6}_route_me_harder() in netns Alexey Dobriyan
2008-09-09 5:44 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 05/33] netns ct: per-netns expectations Alexey Dobriyan
2008-09-09 5:49 ` Patrick McHardy
2008-09-09 7:07 ` Alexey Dobriyan
2008-09-09 7:10 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 06/33] netns ct: per-netns unconfirmed list Alexey Dobriyan
2008-09-09 5:50 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 07/33] netns ct: pass netns pointer to nf_conntrack_in() Alexey Dobriyan
2008-09-09 5:52 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 08/33] netns ct: pass netns pointer to L4 protocol's ->error hook Alexey Dobriyan
2008-09-09 5:54 ` Patrick McHardy
2008-09-08 3:02 ` Alexey Dobriyan [this message]
2008-09-09 5:56 ` [PATCH 09/33] netns ct: per-netns /proc/net/nf_conntrack, /proc/net/stat/nf_conntrack Patrick McHardy
2008-09-08 3:02 ` [PATCH 10/33] netns ct: per-netns /proc/net/nf_conntrack_expect Alexey Dobriyan
2008-09-09 5:57 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 11/33] netns ct: per-netns /proc/net/ip_conntrack, /proc/net/stat/ip_conntrack, /proc/net/ip_conntrack_expect Alexey Dobriyan
2008-09-09 5:59 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 12/33] netns ct: export netns list Alexey Dobriyan
2008-09-09 5:59 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 13/33] netns ct: unregister helper in every netns Alexey Dobriyan
2008-09-09 6:01 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 14/33] netns ct: cleanup after L3 and L4 proto unregister " Alexey Dobriyan
2008-09-09 6:03 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 15/33] netns ct: pass conntrack to nf_conntrack_event_cache() not skb Alexey Dobriyan
2008-09-09 6:04 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 16/33] netns ct: per-netns event cache Alexey Dobriyan
[not found] ` <1220842990-30500-16-git-send-email-adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-09-09 6:12 ` Patrick McHardy
2008-09-09 7:07 ` Alexey Dobriyan
2008-09-09 7:07 ` Patrick McHardy
2008-09-09 7:16 ` Patrick McHardy
2008-09-08 3:02 ` [PATCH 17/33] netns ct: final init_net tweaks Alexey Dobriyan
2008-09-09 7:20 ` Patrick McHardy
2008-09-09 7:32 ` Alexey Dobriyan
2008-09-09 7:51 ` Patrick McHardy
2008-09-13 10:45 ` Alexey Dobriyan
2008-09-27 0:00 ` Alexey Dobriyan
2008-09-28 10:31 ` Patrick McHardy
2008-09-13 10:48 ` [PATCH v2 1/6] netns ct: per-netns statistics Alexey Dobriyan
2008-10-02 7:58 ` Patrick McHardy
2008-09-13 10:49 ` [PATCH v2 2/6] netns ct: per-netns /proc/net/stat/nf_conntrack , /proc/net/stat/ip_conntrack Alexey Dobriyan
2008-10-02 7:59 ` Patrick McHardy
2008-09-13 10:51 ` [PATCH v2 3/6] netns ct: per-netns net.netfilter.nf_conntrack_count sysctl Alexey Dobriyan
2008-10-02 8:00 ` Patrick McHardy
2008-09-13 10:52 ` [PATCH v2 4/6] netns ct: per-netns net.netfilter.nf_conntrack_checksum sysctl Alexey Dobriyan
2008-10-02 8:02 ` Patrick McHardy
2008-09-13 10:53 ` [PATCH v2 5/6] netns ct: per-netns net.netfilter.nf_conntrack_log_invalid sysctl Alexey Dobriyan
2008-10-02 8:04 ` Patrick McHardy
2008-09-13 10:55 ` [PATCH v2 6/6] netns ct: per-netns conntrack accounting Alexey Dobriyan
2008-09-26 23:59 ` [PATCH v2 7/6] netns ct: final netns tweaks Alexey Dobriyan
2008-10-02 8:11 ` Patrick McHardy
2008-10-02 8:06 ` [PATCH v2 6/6] netns ct: per-netns conntrack accounting Patrick McHardy
2008-09-08 3:02 ` [PATCH 17/33] netns ct: final init_net tweaks Alexey Dobriyan
2008-09-08 3:02 ` [PATCH 19/33] netns ct: per-netns /proc/net/stat/nf_conntrack, /proc/net/stat/ip_conntrack Alexey Dobriyan
2008-09-08 3:02 ` [PATCH 20/33] netns ct: per-netns net.netfilter.nf_conntrack_count sysctl Alexey Dobriyan
2008-09-08 3:02 ` [PATCH 21/33] netns ct: per-netns net.netfilter.nf_conntrack_checksum sysctl Alexey Dobriyan
2008-09-08 3:02 ` [PATCH 22/33] netns ct: per-netns net.netfilter.nf_conntrack_log_invalid sysctl Alexey Dobriyan
2008-09-08 3:03 ` Alexey Dobriyan
2008-09-08 3:03 ` [PATCH 24/33] netns ct: SIP conntracking in netns Alexey Dobriyan
2008-10-02 8:52 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 25/33] netns ct: H323 " Alexey Dobriyan
2008-10-02 8:52 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 26/33] netns ct: GRE " Alexey Dobriyan
2008-10-02 8:53 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 27/33] netns ct: PPTP " Alexey Dobriyan
2008-10-02 8:54 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 28/33] netns nat: fix ipt_MASQUERADE " Alexey Dobriyan
2008-10-02 9:06 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 29/33] netns nat: per-netns NAT table Alexey Dobriyan
2008-10-02 9:08 ` Patrick McHardy
2008-10-02 9:09 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 30/33] netns nat: per-netns bysource hash Alexey Dobriyan
2008-10-02 9:09 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 31/33] netns ct: fixup DNAT in netns Alexey Dobriyan
2008-10-02 9:10 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 32/33] netns nat: PPTP NAT " Alexey Dobriyan
2008-10-02 9:11 ` Patrick McHardy
2008-09-08 3:03 ` [PATCH 33/33] Enable netfilter " Alexey Dobriyan
2008-10-02 9:12 ` Patrick McHardy
2008-10-02 9:51 ` Alexey Dobriyan
2008-10-02 10:00 ` Patrick McHardy
2008-10-02 9:53 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220842990-30500-9-git-send-email-adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).