Netdev List
 help / color / mirror / Atom feed
From: "Eilon Greenstein" <eilong@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Yitchak Gertner" <yitchak.gertner@broadcom.com>
Subject: Re: [PATCH] bnx2x: EEH recovery fix
Date: Tue, 09 Sep 2008 12:34:49 +0300	[thread overview]
Message-ID: <1220952889.15079.3.camel@lb-tlvb-eliezer> (raw)
In-Reply-To: <20080908.124743.30466861.davem@davemloft.net>


On Mon, 2008-09-08 at 12:47 -0700, David Miller wrote:
> From: "Eilon Greenstein" <eilong@broadcom.com>
> Date: Mon, 8 Sep 2008 03:22:32 -0700
> 
> > The EEH mechanism caused a fatal error when using the bnx2x since
> > the driver attempted accessing the device after it was reset by the
> > EEH. This patch sets a proper unload when EEH error is detected
> > without accessing the device.
> >
> > Since the current implementation causes a fatal error, I ask that
> > you will consider applying this patch.
> 
> What user has run into and reported this failure, and is it
> a regression compared to 2.6.26?

IBM found it on PPC and it was more obvious with the DMA mapping
violation. It is broken in the same way on 2.6.26 as well.
 
> 
> That is the criteria for my putting this patch in now.
> 
> Since EEH triggers are an exceedingly corner case error condition,
> this puts this patch even less valid to go in outside of the merge
> window.
> 
If you cannot accept it into 2.6.27, I will re-send it into net-next.
Please let me know.

Thanks,
Eilon



  reply	other threads:[~2008-09-09  9:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 10:22 [PATCH] bnx2x: EEH recovery fix Eilon Greenstein
2008-09-08 19:47 ` David Miller
2008-09-09  9:34   ` Eilon Greenstein [this message]
2008-09-09  9:59     ` David Miller
2008-09-09 21:08   ` Paul Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220952889.15079.3.camel@lb-tlvb-eliezer \
    --to=eilong@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yitchak.gertner@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox