Netdev List
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: ipv6 neighbour code keeps interfaces held
Date: Thu, 11 Sep 2008 01:57:33 +0200	[thread overview]
Message-ID: <1221091053.3804.53.camel@johannes.berg> (raw)
In-Reply-To: <20080910.164009.92497081.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Wed, 2008-09-10 at 16:40 -0700, David Miller wrote:

> This is yet another side effect of how ipv6 handles ICMP routes
> seperately from "real" ipv6 routes.

I have no idea :) I just had never seen this on a wired interface and
wanted to see if it was mac80211's fault although I couldn't see how it
could have been.

> Anyways, what happens is that when a device goes down a notifier
> goes out, and in IPV6's case it has a notifier registered in
> net/ipv6/addrconf.c that ends up calling rt6_ifdown() on
> the device.
> 
> This is supposed to purge routes from the tree so that the device
> references can be dropped (eventually).
> 
> This is done in ipv6 by fib6_clean_all() but that only handles
> normal routes.  The seperate ICMP6 routes are not purged properly
> in this situation.

And then they time out after 30 seconds? I see the message exactly three
times and then it gets removed.

> Here is a quick patch that might resolve this specific situation.
> Let me know how it works for you:

I'll add it to my tree, but I cannot reproduce the issue at will. It
just happens occasionally when I'm developing.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-09-10 23:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 21:18 ipv6 neighbour code keeps interfaces held Johannes Berg
2008-09-10 23:40 ` David Miller
2008-09-10 23:57   ` Johannes Berg [this message]
2008-09-11  0:00     ` David Miller
2008-09-11  7:11       ` Rami Rosen
2008-09-11 16:12   ` Johannes Berg
2008-09-11 21:46     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221091053.3804.53.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox