From: Sergey Popovich <popovich_sergei@mail.ru>
To: netdev@vger.kernel.org
Subject: Re: Question about skb_flow_dissect() and 802.1q/802.1ad
Date: Fri, 07 Feb 2014 21:36:42 +0200 [thread overview]
Message-ID: <12212434.KMML02VyKq@tuxracer> (raw)
In-Reply-To: <1391800285.10160.62.camel@edumazet-glaptop2.roam.corp.google.com>
В письме от 7 февраля 2014 11:11:25 пользователь Eric Dumazet написал:
> On Fri, 2014-02-07 at 20:44 +0200, Sergey Popovich wrote:
> Well, all you need is to properly set network header before calling
> skb_flow_dissect()
It seems, network header pointing properly to network protocol header
(IPv4, IPv6 in my case).
But skb->protocol points to htons(ETH_P_8021Q) and skb_flow_dissect()
looks inside network header, not layer 2 where vlan header resides.
Thats main problem with this. layer2+3 and layer3+4 - original bonding
xmit hash policies also affected by skb->protocol == htons(ETH_P_8021Q)
for stacked vlans.
Thanks for quick answer.
>
> All is about headers. hdr and _hdr are vague.
Well, 802.1q != 802.1ad, VLAN != VMAN (QinQ, etc.), I consider this, butthis
is quick patch, no problem with any names. Sorry for this.
Patch only for give a hint on question I ask. Thanks.
--
SP5474-RIPE
Sergey Popovich
prev parent reply other threads:[~2014-02-07 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 18:44 Question about skb_flow_dissect() and 802.1q/802.1ad Sergey Popovich
2014-02-07 19:11 ` Eric Dumazet
2014-02-07 19:36 ` Sergey Popovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12212434.KMML02VyKq@tuxracer \
--to=popovich_sergei@mail.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).