netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Benjamin Li" <benli@broadcom.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: benli@broadcom.com, "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches
Date: Thu, 18 Sep 2008 09:57:09 -0700	[thread overview]
Message-ID: <1221757033-4874-1-git-send-email-benli@broadcom.com> (raw)
In-Reply-To: <20080918063933.GA8027@verge.net.au>

Thanks for the comments Simon.  I have integrated the changes that you have suggested.  I have reposted the entire patch set in numbered form so that it could be merged in easier.

Thanks again.

-Ben

> @@ -7514,7 +7514,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
> >
> >       bp->stats_ticks = USEC_PER_SEC & BNX2_HC_STATS_TICKS_HC_STAT_TICKS;
> >
> > -     bp->timer_interval =  HZ;
> >       bp->current_interval =  HZ;
> 
> Would it make sense to set current_interval to BNX2_TIMER_INTERVAL?

Changed.

> >
> > diff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h
> > index cb47c98..e534c1d 100644
> > --- a/drivers/net/bnx2.h
> > +++ b/drivers/net/bnx2.h
> > @@ -6701,7 +6701,7 @@ struct bnx2 {
> >
> >       /* End of fields used in the performance code paths. */
> >
> > -     int                     timer_interval;
> > +#define BNX2_TIMER_INTERVAL                  HZ
> 
> Perhaps its just me, but would it be nicer to define BNX2_TIMER_INTERVAL
> somewhere other than in the middle of this structure?
> 
Moved outside of the bnx2 structure.

--------------------

Benjamin Li (4):
  bnx2: In bnx2_set_mac_link() return void rather then int
  bnx2: Update MODULE_DESCRIPTION to include the 5716
  bnx2: Remove name field from bnx2 structure
  bnx2: Remove timer_interval field from the bnx2 structure

 drivers/net/bnx2.c |   22 +++++++++-------------
 drivers/net/bnx2.h |    5 ++---
 2 files changed, 11 insertions(+), 16 deletions(-)



       reply	other threads:[~2008-09-18 16:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080918063933.GA8027@verge.net.au>
2008-09-18 16:57 ` Benjamin Li [this message]
2008-09-18 16:57   ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int Benjamin Li
2008-09-18 16:57     ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 Benjamin Li
2008-09-18 16:57       ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from bnx2 structure Benjamin Li
2008-09-18 16:57         ` [UPDATED][NET-NEXT PATCH 4/4] bnx2: Remove timer_interval field from the " Benjamin Li
2008-09-18 23:40           ` David Miller
2008-09-18 23:40         ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from " David Miller
2008-09-18 22:29       ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 David Miller
2008-09-18 23:39       ` David Miller
2008-09-18 23:38     ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int David Miller
2008-09-18 17:04   ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Jeff Garzik
2008-09-18 22:30     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221757033-4874-1-git-send-email-benli@broadcom.com \
    --to=benli@broadcom.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).