From: "Benjamin Li" <benli@broadcom.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: benli@broadcom.com, "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from bnx2 structure
Date: Thu, 18 Sep 2008 09:57:12 -0700 [thread overview]
Message-ID: <1221757033-4874-4-git-send-email-benli@broadcom.com> (raw)
In-Reply-To: <1221757033-4874-3-git-send-email-benli@broadcom.com>
The name of the board is only used during the initialization of
the adapter. We can save the space of a pointer by not storing
this information.
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/bnx2.c | 3 +--
drivers/net/bnx2.h | 2 --
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index a78b664..8417766 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -7718,7 +7718,6 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
memcpy(dev->dev_addr, bp->mac_addr, 6);
memcpy(dev->perm_addr, bp->mac_addr, 6);
- bp->name = board_info[ent->driver_data].name;
dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
if (CHIP_NUM(bp) == CHIP_NUM_5709)
@@ -7745,7 +7744,7 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
printk(KERN_INFO "%s: %s (%c%d) %s found at mem %lx, "
"IRQ %d, node addr %s\n",
dev->name,
- bp->name,
+ board_info[ent->driver_data].name,
((CHIP_ID(bp) & 0xf000) >> 12) + 'A',
((CHIP_ID(bp) & 0x0ff0) >> 4),
bnx2_bus_string(bp, str),
diff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h
index c3c579f..cb47c98 100644
--- a/drivers/net/bnx2.h
+++ b/drivers/net/bnx2.h
@@ -6701,8 +6701,6 @@ struct bnx2 {
/* End of fields used in the performance code paths. */
- char *name;
-
int timer_interval;
int current_interval;
struct timer_list timer;
--
1.6.0.1
next prev parent reply other threads:[~2008-09-18 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080918063933.GA8027@verge.net.au>
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int Benjamin Li
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 Benjamin Li
2008-09-18 16:57 ` Benjamin Li [this message]
2008-09-18 16:57 ` [UPDATED][NET-NEXT PATCH 4/4] bnx2: Remove timer_interval field from the bnx2 structure Benjamin Li
2008-09-18 23:40 ` David Miller
2008-09-18 23:40 ` [UPDATED][NET-NEXT PATCH 3/4] bnx2: Remove name field from " David Miller
2008-09-18 22:29 ` [UPDATED][NET-NEXT PATCH 2/4] bnx2: Update MODULE_DESCRIPTION to include the 5716 David Miller
2008-09-18 23:39 ` David Miller
2008-09-18 23:38 ` [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link() return void rather then int David Miller
2008-09-18 17:04 ` [UPDATED][NET-NEXT PATCH 0/4] Minor bnx2 patches Jeff Garzik
2008-09-18 22:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221757033-4874-4-git-send-email-benli@broadcom.com \
--to=benli@broadcom.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).