netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hao <kexin.hao@windriver.com>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: Chris Snook <csnook@redhat.com>, Jeff Garzik <jeff@garzik.org>,
	Jeff Garzik <jgarzik@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: remove LLTX in atl2 driver
Date: Fri, 26 Sep 2008 09:20:42 +0800	[thread overview]
Message-ID: <1222392042.2682.40.camel@kevin> (raw)
In-Reply-To: <20080925185849.0df482e2@osprey.hogchain.net>

On Thu, 2008-09-25 at 18:58 -0500, Jay Cliburn wrote:
> On Thu, 25 Sep 2008 18:34:29 -0400
> Chris Snook <csnook@redhat.com> wrote:
> 
> > 
> > I'm all in favor of removing legacy cruft.  I want to know a little
> > more about it so we can remove it from the atl1 code as well.
> > Ultimately most of this will be shared code.
> 
> Yes, LLTX can (and should) be removed from the atl1 code.  I had an
> exchange with Herbert Xu and David Miller on LKML a few weeks ago, and
> they gave me a few tips on how to do it, but I haven't yet had the
> time.  What takes an experienced netdev warrior about a half hour to
> implement unfortunately takes me days of after-dayjob time as I track
> through all the calls that that are affected and test the modified
> driver.
> 
> Now back to atl2...  I'd like to hear from Kevin also whether he tested
> the LLTX removal.  I'm building the driver with his patch as we speak,
> and I'll test it myself this weekend, but Kevin I'd still like to know
> if you tested the patch.

Yes, I have tested this driver on a Eee PC. It works well.

Thanks,
Kevin

> 
> Thanks,
> Jay

  reply	other threads:[~2008-09-26  1:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25  0:35 [PATCH] net: remove LLTX in atl2 driver Kevin Hao
2008-09-25 20:30 ` Chris Snook
2008-09-25 20:55   ` Jeff Garzik
2008-09-25 22:34     ` Chris Snook
2008-09-25 23:58       ` Jay Cliburn
2008-09-26  1:20         ` Kevin Hao [this message]
2008-09-26  1:24           ` Chris Snook
2008-09-26  2:20             ` Kevin Hao
2008-09-26  1:24 ` Jay Cliburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222392042.2682.40.camel@kevin \
    --to=kexin.hao@windriver.com \
    --cc=csnook@redhat.com \
    --cc=jacliburn@bellsouth.net \
    --cc=jeff@garzik.org \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).