From: Patrick McManus <mcmanus@ducksong.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: RE: 2.6.27 problem with shaping using netem/ifb (regression?) [TSO]
Date: Thu, 02 Oct 2008 11:49:20 -0400 [thread overview]
Message-ID: <1222962561.7392.7.camel@tng> (raw)
In-Reply-To: <1222912542.6395.30.camel@tng>
Testing a little further, the key element is tso on loopback.
It is off by default for 23->26, and on by default in 27. My script is
always broken whenever I turn tso on for lo regardless of version.
So maybe just a lo/tso interaction problem not a regression.
The change that turned it on by default went into 27-rc4:
commit f22f8567cb0a530d8958d177e0f268783bd0d894
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri Aug 15 14:52:08 2008 -0700
loopback: Enable TSO
This patch enables TSO since the loopback device is naturally
capable of handling packets of any size. This also means that
we won't enable GSO on lo which is good until GSO is fixed to
preserve netfilter state as netfilter treats loopback packets
in a special way.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2008-10-02 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 23:04 2.6.27 problem with shaping using netem/ifb (regression?) Patrick McManus
2008-10-02 1:42 ` Brandeburg, Jesse
2008-10-02 1:55 ` 2.6.27 problem with shaping using netem/ifb (regression?) [TSO] Patrick McManus
2008-10-02 15:49 ` Patrick McManus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222962561.7392.7.camel@tng \
--to=mcmanus@ducksong.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).