From: "Michael Chan" <mchan@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 4/6] bnx2: Eliminate TSO header modifications.
Date: Thu, 09 Oct 2008 13:56:39 -0700 [thread overview]
Message-ID: <1223585799.23468.4.camel@HP1> (raw)
In-Reply-To: <20081009.122558.246831931.davem@davemloft.net>
On Thu, 2008-10-09 at 12:25 -0700, David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Thu, 9 Oct 2008 10:16:06 -0700
>
> > This is now possible with updated firmware.
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Nice, applied.
>
> Quick question, in the intermediate step where we have the
> new firmware (patch #3) but not this change applied (patch
> #4) does TSO still work properly?
It will still work. The firmware will overwrite the header fields
modified (unnecessarily) by the driver.
>
> If TSO is bolixed after patch #3 but before patch #4 please
> don't create those kinds of non-bisectable situations in
> the future. I'd rather you do the firmware update and the
> TSO logic changes all in one go to keep it all working.
>
> Thanks!
>
next prev parent reply other threads:[~2008-10-09 20:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 17:16 [PATCH net-next 1/6] bnx2: Add bnx2_shutdown_chip() Michael Chan
2008-10-09 17:16 ` [PATCH net-next 2/6] bnx2: Check netif_running() in all ethtool operations Michael Chan
2008-10-09 19:22 ` David Miller
2008-10-09 20:59 ` Michael Chan
2008-10-09 21:26 ` David Miller
2008-10-09 17:16 ` [PATCH net-next 4/6] bnx2: Eliminate TSO header modifications Michael Chan
2008-10-09 19:25 ` David Miller
2008-10-09 20:56 ` Michael Chan [this message]
2008-10-09 17:16 ` [PATCH net-next 5/6] bnx2: Handle DMA mapping errors Michael Chan
2008-10-09 19:26 ` David Miller
2008-10-09 17:16 ` [PATCH net-next 6/6] bnx2: Update version to 1.8.1 Michael Chan
2008-10-09 19:27 ` David Miller
2008-10-09 19:21 ` [PATCH net-next 1/6] bnx2: Add bnx2_shutdown_chip() David Miller
[not found] ` <1223572568-1298-3-git-send-email-mchan@broadcom.com>
2008-10-09 19:23 ` [PATCH net-next 3/6] bnx2: Update 5706/5708 firmware David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223585799.23468.4.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox