From: Ben Hutchings <bhutchings@solarflare.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Patrick McHardy <kaber@trash.net>,
Linux Netdev List <netdev@vger.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
e1000-devel@lists.sourceforge.net
Subject: RE: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload
Date: Fri, 10 Oct 2008 18:59:36 +0100 [thread overview]
Message-ID: <1223661576.3984.114.camel@achroite> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F520667243B@orsmsx418.amr.corp.intel.com>
On Fri, 2008-10-10 at 10:48 -0700, Brandeburg, Jesse wrote:
> Patrick McHardy wrote:
> > Patrick McHardy wrote:
> >> This patch changes e1000 to set vlan_features so TSO and CSUM
> >> offload can be used by VLAN devices, similar as with the other Intel
> >> drivers.
> >>
> >> Only RFC because I don't know whether there is buggy hardware
> >> that doesn't support this properly, but feel free to apply in
> >> case there isn't.
> >
> > I never received a response to this. Any comments?
>
> Sorry to delay the reply, the only one that stands out to me as a
> possible problem with the devices that e1000 still supports is the
> NETIF_F_TSO6.
vlan_features is a mask for features. So long as all parts that do
support TSO-IPv6 also support it for VLAN-tagged packets, it should be
safe to set NETIF_F_TSO6 in vlan_features unconditionally.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2008-10-10 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 10:05 [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload Patrick McHardy
2008-10-10 14:39 ` Patrick McHardy
2008-10-10 17:48 ` Brandeburg, Jesse
2008-10-10 17:59 ` Ben Hutchings [this message]
2008-10-10 19:09 ` David Miller
2008-10-10 22:01 ` Brandeburg, Jesse
2008-10-10 22:11 ` David Miller
2008-10-10 17:50 ` Brandeburg, Jesse
2008-10-11 14:35 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223661576.3984.114.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).