From: "Michael Chan" <mchan@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"David Miller" <davem@davemloft.net>,
"berni@birkenwald.de" <berni@birkenwald.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WARNING (skb_gso_segment) with tg3+bridge in 2.6.27
Date: Thu, 23 Oct 2008 10:13:25 -0700 [thread overview]
Message-ID: <1224782005.9142.2.camel@HP1> (raw)
In-Reply-To: <20081023022001.GB304@gondor.apana.org.au>
On Wed, 2008-10-22 at 19:20 -0700, Herbert Xu wrote:
> What I meant is the NETIF_F_TSO6 bit vs. NETIF_F_IPV6_CSUM bit.
> My question is essentially does having the first bit always mean
> that the second bit is set. The second bit stands for support
> of TCPv6 and UDPv6 checksum offload (which is not necessarily
> related to TSO or UFO).
>
> The thing which I wasn't sure about is that the conditions which
> determine which one of these bits are set do not look the same
> in tg3.
>
Yes, NETIF_F_TSO6 chips are a subset of NETIF_F_IPV6_CSUM chips. In the
code, these 2 bits are set independently and so the relationship is not
obvious. We should probably rearrange the code to make things more
clear.
Thanks.
next prev parent reply other threads:[~2008-10-23 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 17:20 WARNING (skb_gso_segment) with tg3+bridge in 2.6.27 Bernhard Schmidt
2008-10-13 7:42 ` David Miller
2008-10-13 7:59 ` Herbert Xu
2008-10-22 7:45 ` Herbert Xu
2008-10-22 17:57 ` Matt Carlson
2008-10-23 2:20 ` Herbert Xu
2008-10-23 17:13 ` Michael Chan [this message]
2008-10-24 14:33 ` Herbert Xu
2009-05-07 21:23 ` Ferenc Wágner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224782005.9142.2.camel@HP1 \
--to=mchan@broadcom.com \
--cc=berni@birkenwald.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).