From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH] add %pM printf format specifier
Date: Sun, 26 Oct 2008 12:01:14 -0700
Message-ID: <1225047674.10060.10.camel@brick>
References: <1224892008.3919.27.camel@johannes.berg>
	 <49035AF0.6040700@anduras.de> <1225008096.3478.3.camel@johannes.berg>
	 <20081026.010329.11475786.davem@davemloft.net>
	 <1225009308.3478.22.camel@johannes.berg>
	 <1225009822.3478.30.camel@johannes.berg>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, anders@anduras.de,
	netdev@vger.kernel.org
To: Johannes Berg <johannes@sipsolutions.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from rv-out-0506.google.com ([209.85.198.236]:3028 "EHLO
	rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755715AbYJZTBT (ORCPT
	<rfc822;netdev@vger.kernel.org>); Sun, 26 Oct 2008 15:01:19 -0400
Received: by rv-out-0506.google.com with SMTP id k40so1771078rvb.1
        for <netdev@vger.kernel.org>; Sun, 26 Oct 2008 12:01:18 -0700 (PDT)
In-Reply-To: <1225009822.3478.30.camel@johannes.berg>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sun, 2008-10-26 at 09:30 +0100, Johannes Berg wrote:
> static char *ip6_string(char *buf, char *end, be16 *addr, int field_width, int precision, int flags)
> {
> 	char ip6[8*5];
> 	char *p = ip6;
> 	int i;
> 	u16 tmp;
> 
> 	for (i=0; i<7; i++) {
> 		tmp = cpu_to_le16(addr[i]);

		tmp = be16_to_cpup(addr + i);

> 		p = pack_hex_byte(p, tmp >> 8);
> 		p = pack_hex_byte(p, tmp & 0xFF);
> 		if (!(flags & SPECIAL))
> 			*p++ = ':';
> 	}
> 	tmp = cpu_to_le16(addr[7]);

	tmp = be16_to_cpup(addr + 7);

Or maybe just cast addr to char * and avoid the byteswapping altogether.

Just a thought,

Harvey