netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: johannes@sipsolutions.net, anders@anduras.de,
	netdev@vger.kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHv3] printk: add %pM format specifier for MAC addresses
Date: Mon, 27 Oct 2008 16:14:14 -0700	[thread overview]
Message-ID: <1225149254.6339.4.camel@brick> (raw)
In-Reply-To: <20081027.154736.178482850.davem@davemloft.net>

On Mon, 2008-10-27 at 15:47 -0700, David Miller wrote:
> From: Harvey Harrison <harvey.harrison@gmail.com>
> Date: Mon, 27 Oct 2008 12:59:02 -0700
> 
> > Add format specifiers for printing out six colon-separated bytes:
> > 
> > MAC addresses (%pM):
> > xx:xx:xx:xx:xx:xx
> > 
> > %#pM is also supported and omits the colon separators.
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> 
> Applied, thanks.

Did you happen to have a preference with regard to the specifier for
IPv6 addresses:

I was thinking of using %pI6 to replace NIP6() and NIP6_FMT and using
%#pI6 for NIP6_SEQFMT.

On the IPv4 side, maybe use %pI4 for network endian NIPQUAD() and NIPQUAD_FMT
and then %#pI4 for host-endian HIQUAD(), as displaying the IPv4 address without
the periods isn't useful?

What do you think of that?

Harvey

  reply	other threads:[~2008-10-27 23:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 23:46 [PATCH] add %pM printf format specifier Johannes Berg
2008-10-25  1:41 ` Joe Perches
2008-10-25  8:00   ` Johannes Berg
2008-10-25 17:44 ` Sven Anders
2008-10-26  8:01   ` Johannes Berg
2008-10-26  8:03     ` David Miller
2008-10-26  8:21       ` Johannes Berg
2008-10-26  8:30         ` Johannes Berg
2008-10-26 19:01           ` Harvey Harrison
2008-10-26 19:33             ` Johannes Berg
2008-10-26 19:38               ` Harvey Harrison
2008-10-26 19:40                 ` Johannes Berg
2008-10-26 22:39                   ` [RFC PATCH] printk: add the %pM, %p4, %p6 format specifiers Harvey Harrison
2008-10-27  0:31                     ` [RFC PATCHv2] " Harvey Harrison
2008-10-27  1:21                       ` Frans Pop
2008-10-27  2:08                         ` H. Peter Anvin
2008-10-27  6:59                       ` Johannes Berg
2008-10-27 16:28                         ` Harvey Harrison
2008-10-27 19:38                           ` David Miller
2008-10-27 19:47                             ` Johannes Berg
2008-10-27 19:59                             ` [RFC PATCHv3] printk: add %pM format specifier for MAC addresses Harvey Harrison
2008-10-27 21:55                               ` Joe Perches
2008-10-27 22:46                                 ` David Miller
2008-10-27 22:47                               ` David Miller
2008-10-27 23:14                                 ` Harvey Harrison [this message]
2008-10-27 23:31                                   ` Alexey Dobriyan
2008-10-27 23:48                                   ` Joe Perches
2008-10-28  8:04                                     ` Johannes Berg
2008-10-27 23:55                                   ` David Miller
2008-10-28  0:05                                     ` Harvey Harrison
2008-10-28  0:22                                       ` Joe Perches
2008-10-28  8:06                                         ` Johannes Berg
2008-10-26  8:38         ` [PATCH] add %pM printf format specifier Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225149254.6339.4.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anders@anduras.de \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).