Re: [PATCH] xfrm: Notify changes in UDP encapsulation via netlink

[Martin Willi <martin@strongswan.org>]

> I don't see the code which will actually invoke the new
> ->new_mapping() method (either here or in a follow-on patch), so it's
> impossible to review these changes.

The patch is complete, sorry for being unclear.

xfrm_send_mapping is an implementation of a xfrm_mgr operation. 

>  static struct xfrm_mgr netlink_mgr = {
>         .id             = "netlink",
>         .notify         = xfrm_send_state_notify,
>         .notify_policy  = xfrm_send_policy_notify,
>         .report         = xfrm_send_report,
>         .migrate        = xfrm_send_migrate,
> +       .new_mapping    = xfrm_send_mapping,
> };

This operation is invoked from net/ipv4/esp4.c through the
km_new_mapping() function, km_new_mapping() invokes all registered key
managers. It is already implemented in the PF_KEY interface (pfkeyv2_mgr
in af_key.c), but is missing in the netlink xfrm interface. The patch
adds this functionality to the netlink interface.