From: Joe Perches <joe@perches.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/6v2] netfilter: replace uses of NIP6_FMT with %p6
Date: Tue, 28 Oct 2008 15:42:36 -0700 [thread overview]
Message-ID: <1225233757.5269.211.camel@localhost> (raw)
In-Reply-To: <1225224815.11483.56.camel@brick>
On Tue, 2008-10-28 at 13:13 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> diff --git a/net/netfilter/nf_conntrack_ftp.c
> b/net/netfilter/nf_conntrack_ftp.c
> index 4f71071..a90d463 100644
> --- a/net/netfilter/nf_conntrack_ftp.c
> +++ b/net/netfilter/nf_conntrack_ftp.c
> @@ -467,11 +467,9 @@ static int help(struct sk_buff *skb,
> NIPQUAD(cmd.u3.ip),
> NIPQUAD(ct->tuplehash[dir].tuple.src.u3.ip));
> } else {
> - pr_debug("conntrack_ftp: NOT RECORDING: " NIP6_FMT
> - " != " NIP6_FMT "\n",
> - NIP6(*((struct in6_addr *)cmd.u3.ip6)),
> - NIP6(*((struct in6_addr *)
> - ct->tuplehash[dir].tuple.src.u3.ip6)));
> + pr_debug("conntrack_ftp: NOT RECORDING: %p6 != %p6\n",
> + cmd.u3.ip6,
> + ct->tuplehash[dir].tuple.src.u3.ip6);
> }
I think it's better to change all uses of:
(foo.<ie: ct->tuplehash[dir].tuple.src.>)u3.ip6
to:
&foo.u3.in6
as the union defines a struct in6_addr and not use the
ip6 array which is __be32[4].
next prev parent reply other threads:[~2008-10-28 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 19:54 [PATCH 4/6] netfilter: replace uses of NIP6_FMT with %p6 Harvey Harrison
2008-10-28 20:13 ` [PATCH 4/6v2] " Harvey Harrison
2008-10-28 22:42 ` Joe Perches [this message]
2008-10-28 23:08 ` David Miller
2008-10-28 23:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225233757.5269.211.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).