From: Harvey Harrison <harvey.harrison@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: oh crap... (re: %p6)
Date: Wed, 29 Oct 2008 11:21:19 -0700 [thread overview]
Message-ID: <1225304479.5688.28.camel@brick> (raw)
In-Reply-To: <1225304214.5269.339.camel@localhost>
On Wed, 2008-10-29 at 11:16 -0700, Joe Perches wrote:
> On Wed, 2008-10-29 at 10:24 -0700, Harvey Harrison wrote:
> > Putting a modifier after the format specifier seems a little strange to me.
>
> Harvey, please remember the whole %p<foo> concept is based on
> modifier after format specifier.
>
> I think %p6 followed by combinations of things:
>
> "::" compressed v6, largest block of consecutive 0's replaced with ::
> "-:" no separating colons, use space instead
> "-0" no leading 0's
> ".4" last word as ipv4 dotted decimal
> "x1" u8 form
> "x2" be16
> "x4" be32
> "x8" be64
>
Yes, but if you put anything but alphanumerics after the %p, make sure
you handle that in vsnprintf(), so it will be a bit more involved than
my simplistic ones were.
> So that you could have:
>
> %p6:: 1234:000a::c0a8:0101
> %p6::-0 1234:a::c0a8:0101
> %p6::-0.4 1234:a::192.168.1.1
> %p6-0-:x1 0 1 2 3 4 5 6 7 8 9 a b c d e f
> %p6x1 00:01:02:03:04:05:06:07:09:0a:0b:0c:0d:0e:0f
>
> etc. If acceptable, I'll submit a patch.
>
I'll let Dave comment on whether this flexibility is desired. Mine was
more an attempt to consolidate a very common (and simplisitic) usage.
Cheers,
Harvey
next prev parent reply other threads:[~2008-10-29 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 8:54 oh crap... (re: %p6) David Miller
2008-10-29 14:55 ` Harvey Harrison
2008-10-29 15:39 ` Joe Perches
2008-10-29 17:24 ` Harvey Harrison
2008-10-29 18:16 ` Joe Perches
2008-10-29 18:21 ` Harvey Harrison [this message]
2008-10-29 18:32 ` oh crap David Miller
2008-10-29 18:31 ` David Miller
2008-10-29 19:13 ` Joe Perches
2008-10-29 18:28 ` David Miller
2008-10-29 18:31 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225304479.5688.28.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).