From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harvey Harrison Subject: Re: [PATCH 3/7] net: replace NIPQUAD() in net/netfilter/ Date: Mon, 03 Nov 2008 09:43:16 -0800 Message-ID: <1225734196.5361.5.camel@brick> References: <1225412025.5574.34.camel@brick> <43ca39800811030856u5acf9601s6aef81887f19f859@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: David Miller , linux-netdev To: Julius Volz Return-path: Received: from mail-gx0-f15.google.com ([209.85.217.15]:33370 "EHLO mail-gx0-f15.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbYKCRnV (ORCPT ); Mon, 3 Nov 2008 12:43:21 -0500 Received: by gxk8 with SMTP id 8so1029870gxk.1 for ; Mon, 03 Nov 2008 09:43:19 -0800 (PST) In-Reply-To: <43ca39800811030856u5acf9601s6aef81887f19f859@mail.gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2008-11-03 at 17:56 +0100, Julius Volz wrote: > Hi, > I just noticed that this breaks IPv4 addresses in IPVS debug output > (didn't check in other places). It seems that during integer to ASCII > conversion, the converted digits are output the wrong way around (not > endianness though). For example, 10.0.0.254 is output as 01.0.0.452. > Could something be wrong with ip4_addr_string() or put_dec_trunc() in > lib/vsprintf.c? Mea Culpa, I was testing with a too-simple case, it does reverse the digits, can you try this: From: Harvey Harrison [PATCH] printk: ipv4 address digits printed in reverse order put_dec_trunc prints the digits in reverse order and is reversed inside number(). Continue using put_dec_trunc, but reverse each quad in ip4_addr_string. [Noticed by Julius Volz] Signed-off-by: Harvey Harrison --- lib/vsprintf.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index dd7cc7f..6897724 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -620,11 +620,15 @@ static char *ip4_addr_string(char *buf, char *end, u8 *addr, int field_width, int precision, int flags) { char ip4_addr[4 * 4]; /* (4 * 3 decimal digits), 3 dots and trailing zero */ + char temp[3]; /* hold each IP quad in reverse order */ char *p = ip4_addr; - int i; + int i, digits; for (i = 0; i < 4; i++) { - p = put_dec_trunc(p, addr[i]); + digits = put_dec_trunc(temp, addr[i]) - temp; + /* reverse the digits in the quad */ + while (digits--) + *p++ = temp[digits]; if (i != 3) *p++ = '.'; } -- 1.6.0.3.756.gb776d