From: Mark McLoughlin <markmc@redhat.com>
To: netdev@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Max Krasnyansky <maxk@qualcomm.com>,
Mark McLoughlin <markmc@redhat.com>
Subject: [PATCH] tun: don't set NETIF_F_FRAGLIST
Date: Wed, 5 Nov 2008 12:36:27 +0000 [thread overview]
Message-ID: <1225888587-1387-1-git-send-email-markmc@redhat.com> (raw)
In-Reply-To: <>
We don't handle skb_shared_info->frag_list, so we shouldn't
be setting the NETIF_F_FRAGLIST flag.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
drivers/net/tun.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 33b6d1b..7f9084c 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -844,11 +844,11 @@ static int set_offload(struct net_device *dev, unsigned long arg)
old_features = dev->features;
/* Unset features, set them as we chew on the arg. */
- features = (old_features & ~(NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST
+ features = (old_features & ~(NETIF_F_HW_CSUM|NETIF_F_SG
|NETIF_F_TSO_ECN|NETIF_F_TSO|NETIF_F_TSO6));
if (arg & TUN_F_CSUM) {
- features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
+ features |= NETIF_F_HW_CSUM|NETIF_F_SG;
arg &= ~TUN_F_CSUM;
if (arg & (TUN_F_TSO4|TUN_F_TSO6)) {
--
1.5.4.3
reply other threads:[~2008-11-05 12:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225888587-1387-1-git-send-email-markmc@redhat.com \
--to=markmc@redhat.com \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).