From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, jgarzik@redhat.com
Subject: Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings
Date: Thu, 06 Nov 2008 12:33:15 +0000 [thread overview]
Message-ID: <1225974795.3150.1.camel@achroite> (raw)
In-Reply-To: <49128300.1000602@garzik.org>
On Thu, 2008-11-06 at 00:39 -0500, Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_write_limit':
> > drivers/net/sfc/falcon.c:1679: warning: comparison of distinct pointer types lacks a cast
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_read':
> > drivers/net/sfc/falcon.c:1720: warning: comparison of distinct pointer types lacks a cast
> >
> > Driver seems rather confused about types. Try to help it.
[...]
> I would prefer min_t()...
Andrew has dropped this patch as it is no longer applicable. I do have
a patch to clean up the length types which I'll submit later.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2008-11-06 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:22 [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings akpm
2008-10-29 21:29 ` Ben Hutchings
2008-10-29 21:35 ` Andrew Morton
2008-11-06 5:39 ` Jeff Garzik
2008-11-06 12:33 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225974795.3150.1.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).