netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Cc: linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] phonet: sparse annotations of protocol, remove forward declaration
Date: Fri, 07 Nov 2008 12:02:01 -0800	[thread overview]
Message-ID: <1226088121.11596.55.camel@brick> (raw)
In-Reply-To: <200811071041.41787.remi.denis-courmont@nokia.com>

On Fri, 2008-11-07 at 10:41 +0200, Rémi Denis-Courmont wrote:
> On Friday 07 November 2008 03:53:13 ext Harvey Harrison, you wrote:
> > net/phonet/af_phonet.c:38:36: error: marked inline, but without a
> > definition
> > net/phonet/pep-gprs.c:63:10: warning: incorrect type in return 
> > expression (different base types)
> > net/phonet/pep-gprs.c:63:10:    expected int
> > net/phonet/pep-gprs.c:63:10:    got restricted __be16 [usertype]
> > <noident> 
> > net/phonet/pep-gprs.c:65:10: warning: incorrect type in return
> > expression 
> > (different base types)
> > net/phonet/pep-gprs.c:65:10:    expected int 
> > net/phonet/pep-gprs.c:65:10:    got restricted __be16 [usertype]
> > <noident> 
> > net/phonet/pep-gprs.c:124:16: warning: incorrect type in assignment
> > (different base types)
> > net/phonet/pep-gprs.c:124:16:    expected restricted 
> > __be16 [usertype] protocol
> > net/phonet/pep-gprs.c:124:16:    got unsigned short [unsigned]
> > [usertype] protocol 
> 
> Thanks. May I ask where the documentation to run these checks is?
> 

You need to add the -D__CHECK_ENDIAN__ flag to sparse to enable these
checks.

make C=1 CF=-D__CHECK_ENDIAN__

should do the trick if you have sparse already.

Harvey


      reply	other threads:[~2008-11-07 20:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  1:53 [PATCH] phonet: sparse annotations of protocol, remove forward declaration Harvey Harrison
2008-11-07  7:11 ` David Miller
2008-11-07  8:41 ` Rémi Denis-Courmont
2008-11-07 20:02   ` Harvey Harrison [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226088121.11596.55.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=remi.denis-courmont@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).