From: "Michael Chan" <mchan@broadcom.com>
To: "Neil Horman" <nhorman@tuxdriver.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
"'davem@davemloft.net'" <davem@davemloft.net>
Subject: Re: [PATCH] bnx2: fix poll_controller method so that proper structures are passed and all rx queues are checked
Date: Tue, 11 Nov 2008 09:59:24 -0800 [thread overview]
Message-ID: <1226426364.23218.14.camel@HP1> (raw)
In-Reply-To: <20081111173708.GC30481@hmsreliant.think-freely.org>
On Tue, 2008-11-11 at 09:37 -0800, Neil Horman wrote:
> Copy that. Here you go, followon patch to change how we pass the irq vector to
> bnx2_interrupt. Doesn't do anything super-usefull, but good for the sake of
> correctness
Sorry, I missed something earlier. After looking at this more closely,
we should also move disable_irq() into the loop and call it with the
same vector values from irq_tbl.
Thanks.
>
> Regards
> Neil
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
>
> bnx2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index 9e1f0e3..cad8b7a 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -7208,7 +7208,7 @@ poll_bnx2(struct net_device *dev)
>
> disable_irq(bp->pdev->irq);
> for (i = 0; i < bp->irq_nvecs; i++)
> - bnx2_interrupt(bp->pdev->irq, &bp->bnx2_napi[i]);
> + bnx2_interrupt(bp->irq_tbl[i].vector, &bp->bnx2_napi[i]);
> enable_irq(bp->pdev->irq);
> }
> #endif
next prev parent reply other threads:[~2008-11-11 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 14:00 [PATCH] bnx2: fix poll_controller method so that proper structures are passed and all rx queues are checked Neil Horman
2008-11-11 14:43 ` Andy Gospodarek
2008-11-11 15:12 ` Michael Chan
2008-11-11 16:46 ` Neil Horman
2008-11-11 17:09 ` Michael Chan
2008-11-11 17:37 ` Neil Horman
2008-11-11 17:59 ` Michael Chan [this message]
2008-11-11 20:58 ` Neil Horman
2008-11-13 0:23 ` David Miller
2008-11-13 1:09 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226426364.23218.14.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).