Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter

David Miller
2008-11-13T22:19:01Z

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Thu, 13 Nov 2008 10:10:12 +0100

> On Wed, 2008-11-12 at 04:11 -0800, David Miller wrote:
> > From: David Miller <davem@davemloft.net>
> > Date: Wed, 12 Nov 2008 03:52:40 -0800 (PST)
> >
> > > Ok, Jesper, please try two things for me, leave the debugging patch
> > > in there for all the tests:
> > >
> > > 1) Retrigger the problem (with or without MSI, doesn't matter) but
> > > add back in that test I asked you to try last week. The one
> > > where the "if (++rp->mark_counter == rp->mark_freq)" condition
> > > test in niu_start_xmit() is commented out, so that the
> > > "mrk |= TX_DESC_MARK;" statement always runs.
> > >
> > > Get me the log dump produced by that scenerio.
>
> ------------[ cut here ]------------
> WARNING: at net/sched/sch_generic.c:226 dev_watchdog+0x21e/0x230()
> NETDEV WATCHDOG: eth2 (niu): transmit timed out
> Modules linked in: niu ipmi_si hpwdt serio_raw bnx2 zlib_inflate rng_core ipmi_msghandler hpilo ehci_hcd uhci_hcd sr_mod cdrom
> Pid: 0, comm: swapper Not tainted 2.6.28-rc4-davem #17
> Call Trace:

Thanks a lot for making this test Jesper, even though the bug
is fixed.

> niu 0000:0b:00.0: niu: eth2: TX_RING[ 5] CHANNEL 5 LDN 37
> niu 0000:0b:00.0: niu: eth2: TX_RING[ 5] parent->lgd_map[ldn] 2
> niu 0000:0b:00.0: niu: eth2: TX_RING[ 5] Num pending TX SKBs: 237
> niu 0000:0b:00.0: niu: eth2: TX_RING[ 5] TX_CS sw[00ed00ec00000000] hw[00ed00ec00000000]

Same signature, counters advancing yet no mark bits are set.

Now if we can fix that MSIX BUG() and start analyzing your
pps performance with oprofile, we'll be in good shape :)