Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter

Jesper Dangaard Brouer
2008-11-13T10:29:49Z

On Wed, 2008-11-12 at 04:11 -0800, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 12 Nov 2008 03:52:40 -0800 (PST)
>
> > Ok, Jesper, please try two things for me, leave the debugging patch
> > in there for all the tests:
> >
> > 1) Retrigger the problem (with or without MSI, doesn't matter) but
> > add back in that test I asked you to try last week. The one
> > where the "if (++rp->mark_counter == rp->mark_freq)" condition
> > test in niu_start_xmit() is commented out, so that the
> > "mrk |= TX_DESC_MARK;" statement always runs.
> >
> > Get me the log dump produced by that scenerio.
> >
> > 2) Next, simply comment out the:
> >
> > if (unlikely(!(cs & (TX_CS_MK | TX_CS_MMK))))
> > goto out;
> >
> > lines in niu_tx_work().
> >
> > Let's see what new info we can get out of this.

Both applying test#1 and test#2.

After applying test#2, I cannot get it to do a TX transmit timed out.
And every thing seem to work... which after the known bug fix was kind
of the expected behaviour...

Although I'm not happy about the new perf numbers, as I now on a SMP
system only can route approx 290 kpps, remember I could route 319 kpps
using a single CPU nosmp kernel. (even more anyoing is that oprofile is
broken)

--
Med venlig hilsen / Best regards
Jesper Brouer
ComX Networks A/S
Linux Network developer
Cand. Scient Datalog / MSc.
Author of http://adsl-optimizer.dk
LinkedIn: http://www.linkedin.com/in/brouer