Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter

Matheos Worku
2008-11-12T23:13:17Z

Jesper Dangaard Brouer wrote:

>
> Hi Google,
>
> On Wed, 12 Nov 2008, David Miller wrote:
>
>> Guess what that does? The packet counters live in the upper
>> 32-bits and the MARK bits live in the lower 32-bits of the
>> TX_CS register.
>>
>> So it first reads the packet counters, and as a side effect that
>> clears the MARK bits in the TX_CS register. So when we read the lower
>> 32-bits the MARK bits are always seen as zero.
>
>
> For the thorough reader, the TX_CS Transmit Control and Status
> register is described in table 26-15 page 761-762 in the PDF document
> titled: "UltraSPARC T2 supplement to UltraSPARC architecture 2007",
> downloadable from:
> http://opensparc-t2.sunsource.net/specs/UST2-UASuppl-current-draft-HP-EXT.pdf
>
>
> Cheers,
> Jesper Brouer
>
> --
> -------------------------------------------------------------------
> MSc. Master of Computer Science
> Dept. of Computer Science, University of Copenhagen
> Author of http://www.adsl-optimizer.dk
> -------------------------------------------------------------------
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

The niu/neptune HW puts some requirement on 32 bit reads of 64 bit
registers. You need to read the lower 32 bits first and then the upper
32 bits. The same ordering applies to writes as well.
On some 64 bit platforms, the 64 bit reads are split into two 32 bit
reads as well, regardless of the OS.

Regards
Matheos