* [PATCH] net: ip_sockglue.c add static, annotate ports' endianness
@ 2008-11-18 20:24 Harvey Harrison
2008-11-20 9:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-11-18 20:24 UTC (permalink / raw)
To: David Miller; +Cc: linux-netdev
Fixes sparse warnings:
net/ipv4/ip_sockglue.c:146:15: warning: incorrect type in assignment (different base types)
net/ipv4/ip_sockglue.c:146:15: expected restricted __be16 [assigned] [usertype] sin_port
net/ipv4/ip_sockglue.c:146:15: got unsigned short [unsigned] [short] [usertype] <noident>
net/ipv4/ip_sockglue.c:130:6: warning: symbol 'ip_cmsg_recv_dstaddr' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
These are new warnings between next-20081117 and next-20081118
net/ipv4/ip_sockglue.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index 624b534..43c0585 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -127,11 +127,11 @@ static void ip_cmsg_recv_security(struct msghdr *msg, struct sk_buff *skb)
security_release_secctx(secdata, seclen);
}
-void ip_cmsg_recv_dstaddr(struct msghdr *msg, struct sk_buff *skb)
+static void ip_cmsg_recv_dstaddr(struct msghdr *msg, struct sk_buff *skb)
{
struct sockaddr_in sin;
struct iphdr *iph = ip_hdr(skb);
- u16 *ports = (u16 *) skb_transport_header(skb);
+ __be16 *ports = (__be16 *)skb_transport_header(skb);
if (skb_transport_offset(skb) + 4 > skb->len)
return;
--
1.6.0.4.994.g16bd3e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ip_sockglue.c add static, annotate ports' endianness
2008-11-18 20:24 [PATCH] net: ip_sockglue.c add static, annotate ports' endianness Harvey Harrison
@ 2008-11-20 9:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-11-20 9:54 UTC (permalink / raw)
To: harvey.harrison; +Cc: netdev
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Tue, 18 Nov 2008 12:24:01 -0800
> Fixes sparse warnings:
> net/ipv4/ip_sockglue.c:146:15: warning: incorrect type in assignment (different base types)
> net/ipv4/ip_sockglue.c:146:15: expected restricted __be16 [assigned] [usertype] sin_port
> net/ipv4/ip_sockglue.c:146:15: got unsigned short [unsigned] [short] [usertype] <noident>
> net/ipv4/ip_sockglue.c:130:6: warning: symbol 'ip_cmsg_recv_dstaddr' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> These are new warnings between next-20081117 and next-20081118
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-20 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-18 20:24 [PATCH] net: ip_sockglue.c add static, annotate ports' endianness Harvey Harrison
2008-11-20 9:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).