netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: davem@davemloft.net
Cc: herbert@gondor.apana.org.au, kuznet@ms2.inr.ac.ru,
	netdev@vger.kernel.org, containers@lists.linux-foundation.org,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: [PATCH 52/53] netns xfrm: /proc/net/xfrm_stat in netns
Date: Tue, 25 Nov 2008 20:27:24 +0300	[thread overview]
Message-ID: <1227634045-27534-52-git-send-email-adobriyan@gmail.com> (raw)
In-Reply-To: <1227634045-27534-51-git-send-email-adobriyan@gmail.com>

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
 include/net/xfrm.h     |    3 ++-
 net/xfrm/xfrm_policy.c |   11 +++++++----
 net/xfrm/xfrm_proc.c   |   26 ++++++++++++--------------
 3 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 78ec3e8..1554ccd 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -1306,7 +1306,8 @@ static inline void xfrm6_fini(void)
 #endif
 
 #ifdef CONFIG_XFRM_STATISTICS
-extern int xfrm_proc_init(void);
+extern int xfrm_proc_init(struct net *net);
+extern void xfrm_proc_fini(struct net *net);
 #endif
 
 extern void xfrm_state_walk_init(struct xfrm_state_walk *walk, u8 proto);
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index e239a25..38822b3 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -2377,14 +2377,20 @@ static struct notifier_block xfrm_dev_notifier = {
 #ifdef CONFIG_XFRM_STATISTICS
 static int __net_init xfrm_statistics_init(struct net *net)
 {
+	int rv;
+
 	if (snmp_mib_init((void **)net->mib.xfrm_statistics,
 			  sizeof(struct linux_xfrm_mib)) < 0)
 		return -ENOMEM;
-	return 0;
+	rv = xfrm_proc_init(net);
+	if (rv < 0)
+		snmp_mib_free((void **)net->mib.xfrm_statistics);
+	return rv;
 }
 
 static void xfrm_statistics_fini(struct net *net)
 {
+	xfrm_proc_fini(net);
 	snmp_mib_free((void **)net->mib.xfrm_statistics);
 }
 #else
@@ -2524,9 +2530,6 @@ void __init xfrm_init(void)
 {
 	register_pernet_subsys(&xfrm_net_ops);
 	xfrm_input_init();
-#ifdef CONFIG_XFRM_STATISTICS
-	xfrm_proc_init();
-#endif
 }
 
 #ifdef CONFIG_AUDITSYSCALL
diff --git a/net/xfrm/xfrm_proc.c b/net/xfrm/xfrm_proc.c
index 27a2ab9..284eaef 100644
--- a/net/xfrm/xfrm_proc.c
+++ b/net/xfrm/xfrm_proc.c
@@ -59,17 +59,18 @@ fold_field(void *mib[], int offt)
 
 static int xfrm_statistics_seq_show(struct seq_file *seq, void *v)
 {
+	struct net *net = seq->private;
 	int i;
 	for (i=0; xfrm_mib_list[i].name; i++)
 		seq_printf(seq, "%-24s\t%lu\n", xfrm_mib_list[i].name,
-			   fold_field((void **)init_net.mib.xfrm_statistics,
+			   fold_field((void **)net->mib.xfrm_statistics,
 				      xfrm_mib_list[i].entry));
 	return 0;
 }
 
 static int xfrm_statistics_seq_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, xfrm_statistics_seq_show, NULL);
+	return single_open_net(inode, file, xfrm_statistics_seq_show);
 }
 
 static struct file_operations xfrm_statistics_seq_fops = {
@@ -77,21 +78,18 @@ static struct file_operations xfrm_statistics_seq_fops = {
 	.open	 = xfrm_statistics_seq_open,
 	.read	 = seq_read,
 	.llseek	 = seq_lseek,
-	.release = single_release,
+	.release = single_release_net,
 };
 
-int __init xfrm_proc_init(void)
+int __net_init xfrm_proc_init(struct net *net)
 {
-	int rc = 0;
-
-	if (!proc_net_fops_create(&init_net, "xfrm_stat", S_IRUGO,
+	if (!proc_net_fops_create(net, "xfrm_stat", S_IRUGO,
 				  &xfrm_statistics_seq_fops))
-		goto stat_fail;
-
- out:
-	return rc;
+		return -ENOMEM;
+	return 0;
+}
 
- stat_fail:
-	rc = -ENOMEM;
-	goto out;
+void xfrm_proc_fini(struct net *net)
+{
+	proc_net_remove(net, "xfrm_stat");
 }
-- 
1.5.6.5


  reply	other threads:[~2008-11-25 17:25 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 17:26 [PATCH 01/53] xfrm: initialise xfrm_policy_gc_work statically Alexey Dobriyan
2008-11-25 17:26 ` [PATCH 02/53] netns xfrm: add netns boilerplate Alexey Dobriyan
2008-11-25 17:26   ` [PATCH 03/53] netns xfrm: add struct xfrm_state::xs_net Alexey Dobriyan
2008-11-25 17:26     ` [PATCH 04/53] netns xfrm: per-netns xfrm_state_all list Alexey Dobriyan
2008-11-25 17:26       ` [PATCH 05/53] netns xfrm: per-netns xfrm_state_bydst hash Alexey Dobriyan
2008-11-25 17:26         ` [PATCH 06/53] netns xfrm: per-netns xfrm_state_bysrc hash Alexey Dobriyan
2008-11-25 17:26           ` [PATCH 07/53] netns xfrm: per-netns xfrm_state_byspi hash Alexey Dobriyan
2008-11-25 17:26             ` [PATCH 08/53] netns xfrm: per-netns xfrm_state_hmask Alexey Dobriyan
2008-11-25 17:26               ` [PATCH 09/53] netns xfrm: per-netns xfrm_state counts Alexey Dobriyan
2008-11-25 17:26                 ` [PATCH 10/53] netns xfrm: per-netns xfrm_hash_work Alexey Dobriyan
2008-11-25 17:26                   ` [PATCH 11/53] netns xfrm: per-netns state GC list Alexey Dobriyan
2008-11-25 17:26                     ` [PATCH 12/53] netns xfrm: per-netns state GC work Alexey Dobriyan
2008-11-25 17:26                       ` [PATCH 13/53] netns xfrm: per-netns km_waitq Alexey Dobriyan
2008-11-25 17:26                         ` [PATCH 14/53] netns xfrm: add struct xfrm_policy::xp_net Alexey Dobriyan
2008-11-25 17:26                           ` [PATCH 15/53] netns xfrm: per-netns policy list Alexey Dobriyan
2008-11-25 17:26                             ` [PATCH 16/53] netns xfrm: per-netns xfrm_policy_byidx hash Alexey Dobriyan
2008-11-25 17:26                               ` [PATCH 17/53] netns xfrm: per-netns xfrm_policy_byidx hashmask Alexey Dobriyan
2008-11-25 17:26                                 ` [PATCH 18/53] netns xfrm: per-netns inexact policies Alexey Dobriyan
2008-11-25 17:26                                   ` [PATCH 19/53] netns xfrm: per-netns xfrm_policy_bydst hash Alexey Dobriyan
2008-11-25 17:26                                     ` [PATCH 20/53] netns xfrm: per-netns policy counts Alexey Dobriyan
2008-11-25 17:26                                       ` [PATCH 21/53] netns xfrm: per-netns policy hash resizing work Alexey Dobriyan
2008-11-25 17:26                                         ` [PATCH 22/53] netns xfrm: propagate netns into bydst/bysrc/byspi hash functions Alexey Dobriyan
2008-11-25 17:26                                           ` [PATCH 23/53] netns xfrm: trivial netns propagations Alexey Dobriyan
2008-11-25 17:26                                             ` [PATCH 24/53] netns xfrm: state flush in netns Alexey Dobriyan
2008-11-25 17:26                                               ` [PATCH 25/53] netns xfrm: state lookup " Alexey Dobriyan
2008-11-25 17:26                                                 ` [PATCH 26/53] netns xfrm: fixup xfrm_alloc_spi() Alexey Dobriyan
2008-11-25 17:26                                                   ` [PATCH 27/53] netns xfrm: finding states in netns Alexey Dobriyan
2008-11-25 17:27                                                     ` [PATCH 28/53] netns xfrm: state walking " Alexey Dobriyan
2008-11-25 17:27                                                       ` [PATCH 29/53] netns xfrm: propagate netns into policy byidx hash Alexey Dobriyan
2008-11-25 17:27                                                         ` [PATCH 30/53] netns xfrm: policy insertion in netns Alexey Dobriyan
2008-11-25 17:27                                                           ` [PATCH 31/53] netns xfrm: policy flushing " Alexey Dobriyan
2008-11-25 17:27                                                             ` [PATCH 32/53] netns xfrm: finding policy " Alexey Dobriyan
2008-11-25 17:27                                                               ` [PATCH 33/53] netns xfrm: policy walking " Alexey Dobriyan
2008-11-25 17:27                                                                 ` [PATCH 34/53] netns xfrm: lookup " Alexey Dobriyan
2008-11-25 17:27                                                                   ` [PATCH 35/53] netns xfrm: xfrm_policy_check " Alexey Dobriyan
2008-11-25 17:27                                                                     ` [PATCH 36/53] netns xfrm: xfrm_route_forward() " Alexey Dobriyan
2008-11-25 17:27                                                                       ` [PATCH 37/53] netns xfrm: flushing/pruning bundles " Alexey Dobriyan
2008-11-25 17:27                                                                         ` [PATCH 38/53] netns xfrm: dst garbage-collecting " Alexey Dobriyan
2008-11-25 17:27                                                                           ` [PATCH 39/53] netns xfrm: xfrm_input() fixup Alexey Dobriyan
2008-11-25 17:27                                                                             ` [PATCH 40/53] netns xfrm: per-netns NETLINK_XFRM socket Alexey Dobriyan
2008-11-25 17:27                                                                               ` [PATCH 41/53] netns xfrm: xfrm_user module in netns Alexey Dobriyan
2008-11-25 17:27                                                                                 ` [PATCH 42/53] netns xfrm: pass netns with KM notifications Alexey Dobriyan
2008-11-25 17:27                                                                                   ` [PATCH 43/53] netns xfrm: KM reporting in netns Alexey Dobriyan
2008-11-25 17:27                                                                                     ` [PATCH 44/53] netns xfrm: ->dst_lookup " Alexey Dobriyan
2008-11-25 17:27                                                                                       ` [PATCH 45/53] netns xfrm: ->get_saddr " Alexey Dobriyan
2008-11-25 17:27                                                                                         ` [PATCH 46/53] netns xfrm: flush SA/SPDs on netns stop Alexey Dobriyan
2008-11-25 17:27                                                                                           ` [PATCH 47/53] netns PF_KEY: part 1 Alexey Dobriyan
2008-11-25 17:27                                                                                             ` [PATCH 48/53] netns PF_KEY: part 2 Alexey Dobriyan
2008-11-25 17:27                                                                                               ` [PATCH 49/53] netns PF_KEY: per-netns /proc/pfkey Alexey Dobriyan
2008-11-25 17:27                                                                                                 ` [PATCH 50/53] netns xfrm: AH/ESP in netns! Alexey Dobriyan
2008-11-25 17:27                                                                                                   ` [PATCH 51/53] netns xfrm: per-netns MIBs Alexey Dobriyan
2008-11-25 17:27                                                                                                     ` Alexey Dobriyan [this message]
2008-11-25 17:27                                                                                                       ` [PATCH 53/53] netns xfrm: per-netns sysctls Alexey Dobriyan
2008-11-26  2:00                                                                                                         ` David Miller
2008-11-26  2:00                                                                                                       ` [PATCH 52/53] netns xfrm: /proc/net/xfrm_stat in netns David Miller
2008-11-26  1:59                                                                                                     ` [PATCH 51/53] netns xfrm: per-netns MIBs David Miller
2008-11-26  1:59                                                                                                   ` [PATCH 50/53] netns xfrm: AH/ESP in netns! David Miller
2008-11-26  1:59                                                                                                 ` [PATCH 49/53] netns PF_KEY: per-netns /proc/pfkey David Miller
2008-11-26  1:58                                                                                               ` [PATCH 48/53] netns PF_KEY: part 2 David Miller
2008-11-26  1:58                                                                                             ` [PATCH 47/53] netns PF_KEY: part 1 David Miller
2008-11-26  1:57                                                                                           ` [PATCH 46/53] netns xfrm: flush SA/SPDs on netns stop David Miller
2008-11-26  1:56                                                                                         ` [PATCH 45/53] netns xfrm: ->get_saddr in netns David Miller
2008-11-26  1:51                                                                                       ` [PATCH 44/53] netns xfrm: ->dst_lookup " David Miller
2008-11-26  1:51                                                                                     ` [PATCH 43/53] netns xfrm: KM reporting " David Miller
2008-11-26  1:50                                                                                   ` [PATCH 42/53] netns xfrm: pass netns with KM notifications David Miller
     [not found]                                                                                 ` <1227634045-27534-41-git-send-email-adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-26  1:50                                                                                   ` [PATCH 41/53] netns xfrm: xfrm_user module in netns David Miller
2008-11-26  1:38                                                                               ` [PATCH 40/53] netns xfrm: per-netns NETLINK_XFRM socket David Miller
2008-11-26  1:38                                                                             ` [PATCH 39/53] netns xfrm: xfrm_input() fixup David Miller
2008-11-26  1:37                                                                           ` [PATCH 38/53] netns xfrm: dst garbage-collecting in netns David Miller
2008-11-26  1:36                                                                         ` [PATCH 37/53] netns xfrm: flushing/pruning bundles " David Miller
2008-11-26  1:36                                                                       ` [PATCH 36/53] netns xfrm: xfrm_route_forward() " David Miller
2008-11-26  1:35                                                                     ` [PATCH 35/53] netns xfrm: xfrm_policy_check " David Miller
2008-11-26  1:35                                                                   ` [PATCH 34/53] netns xfrm: lookup " David Miller
2008-11-26  1:34                                                                 ` [PATCH 33/53] netns xfrm: policy walking " David Miller
2008-11-26  1:34                                                               ` [PATCH 32/53] netns xfrm: finding policy " David Miller
2008-11-26  1:33                                                             ` [PATCH 31/53] netns xfrm: policy flushing " David Miller
2008-11-26  1:33                                                           ` [PATCH 30/53] netns xfrm: policy insertion " David Miller
2008-11-26  1:32                                                         ` [PATCH 29/53] netns xfrm: propagate netns into policy byidx hash David Miller
2008-11-26  1:32                                                       ` [PATCH 28/53] netns xfrm: state walking in netns David Miller
2008-11-26  1:31                                                     ` [PATCH 27/53] netns xfrm: finding states " David Miller
2008-11-26  1:31                                                   ` [PATCH 26/53] netns xfrm: fixup xfrm_alloc_spi() David Miller
2008-11-26  1:30                                                 ` [PATCH 25/53] netns xfrm: state lookup in netns David Miller
2008-11-26  1:30                                               ` [PATCH 24/53] netns xfrm: state flush " David Miller
2008-11-26  1:29                                             ` [PATCH 23/53] netns xfrm: trivial netns propagations David Miller
2008-11-26  1:29                                           ` [PATCH 22/53] netns xfrm: propagate netns into bydst/bysrc/byspi hash functions David Miller
2008-11-26  1:29                                         ` [PATCH 21/53] netns xfrm: per-netns policy hash resizing work David Miller
2008-11-26  1:24                                       ` [PATCH 20/53] netns xfrm: per-netns policy counts David Miller
2008-11-26  1:23                                     ` [PATCH 19/53] netns xfrm: per-netns xfrm_policy_bydst hash David Miller
2008-11-26  1:23                                   ` [PATCH 18/53] netns xfrm: per-netns inexact policies David Miller
2008-11-26  1:23                                 ` [PATCH 17/53] netns xfrm: per-netns xfrm_policy_byidx hashmask David Miller
2008-11-26  1:22                               ` [PATCH 16/53] netns xfrm: per-netns xfrm_policy_byidx hash David Miller
2008-11-26  1:22                             ` [PATCH 15/53] netns xfrm: per-netns policy list David Miller
2008-11-26  1:21                           ` [PATCH 14/53] netns xfrm: add struct xfrm_policy::xp_net David Miller
2008-11-26  1:21                         ` [PATCH 13/53] netns xfrm: per-netns km_waitq David Miller
2008-11-26  1:20                       ` [PATCH 12/53] netns xfrm: per-netns state GC work David Miller
2008-11-26  1:20                     ` [PATCH 11/53] netns xfrm: per-netns state GC list David Miller
2008-11-26  1:19                   ` [PATCH 10/53] netns xfrm: per-netns xfrm_hash_work David Miller
2008-11-26  1:18                 ` [PATCH 09/53] netns xfrm: per-netns xfrm_state counts David Miller
2008-11-26  1:18               ` [PATCH 08/53] netns xfrm: per-netns xfrm_state_hmask David Miller
2008-11-26  1:17             ` [PATCH 07/53] netns xfrm: per-netns xfrm_state_byspi hash David Miller
2008-11-26  1:17           ` [PATCH 06/53] netns xfrm: per-netns xfrm_state_bysrc hash David Miller
2008-11-26  1:17         ` [PATCH 05/53] netns xfrm: per-netns xfrm_state_bydst hash David Miller
2008-11-26  1:16       ` [PATCH 04/53] netns xfrm: per-netns xfrm_state_all list David Miller
2008-11-26  1:15     ` [PATCH 03/53] netns xfrm: add struct xfrm_state::xs_net David Miller
2008-11-26  4:25       ` Alexey Dobriyan
2008-11-26  1:14   ` [PATCH 02/53] netns xfrm: add netns boilerplate David Miller
2008-11-26  1:14 ` [PATCH 01/53] xfrm: initialise xfrm_policy_gc_work statically David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227634045-27534-52-git-send-email-adobriyan@gmail.com \
    --to=adobriyan@gmail.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).