From: "Michael Chan" <mchan@broadcom.com>
To: "Eric Dumazet" <dada1@cosmosbay.com>
Cc: "linux kernel" <linux-kernel@vger.kernel.org>,
"Linux Netdev List" <netdev@vger.kernel.org>
Subject: Re: [BUG] linux-2.6.28-rc3 regression: IRQ smp_affinities not respected
Date: Wed, 26 Nov 2008 09:14:52 -0800 [thread overview]
Message-ID: <1227719692.13189.7.camel@HP1> (raw)
In-Reply-To: <492D107B.1060303@cosmosbay.com>
On Wed, 2008-11-26 at 01:01 -0800, Eric Dumazet wrote:
> Eric Dumazet a écrit :
> > Michael Chan a écrit :
> >> I believe this may be the patch that broke it:
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ce6fce4295ba727b36fdc73040e444bd1aae64cd
> >>
> >>
> >> I don't remember all the details, but the Broadcom 5708 chip is
> >> affected because it does not support MSI per-vector masking.
> >>
> >> One way to get around is to disable MSI with bnx2 parameter
> >> disable_msi=1.
> >>
>
> >
> > I tried this MSI disabling and yes, it now works.
> >
> > 16: 42726 128 105 106 89
> > 89 145 152 IO-APIC-fasteoi uhci_hcd:usb1, eth0, eth1
> >
>
> I believe the bnx2 driver doesnt work at all if !disable_msi (default setting)
>
> Doing a "echo 0 >/sys/devices/system/cpu/cpu1/online" just freeze network
>
> No messages logged
>
> If loaded with disable_msi=1, the cpu unplug works as expected.
>
> Thats a pretty serious issue.
>
Yes, that's the same issue and it is serious. If MSI is being delivered
to CPU 1 and you then take CPU 1 offline, the MSI will not be delivered
to another CPU.
I think I can detect this problem in bnx2_timer() and try to recover.
I'll post a patch when I have something ready. Thanks.
next prev parent reply other threads:[~2008-11-26 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 6:33 [BUG] linux-2.6.28-rc3 regression: IRQ smp_affinities not respected Eric Dumazet
2008-11-05 6:45 ` Michael Chan
2008-11-05 8:09 ` Eric Dumazet
2008-11-06 1:46 ` Michael Chan
2008-11-26 9:01 ` Eric Dumazet
2008-11-26 17:14 ` Michael Chan [this message]
2008-12-01 23:23 ` Michael Chan
2008-12-02 6:04 ` Eric Dumazet
2008-12-03 8:36 ` David Miller
2008-11-05 9:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227719692.13189.7.camel@HP1 \
--to=mchan@broadcom.com \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).