From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harvey Harrison Subject: Re: [PATCH-mm 8/8] decnet: remove private wrappers of endian helpers Date: Wed, 26 Nov 2008 13:49:04 -0800 Message-ID: <1227736144.5511.131.camel@brick> References: <1227733974.5511.130.camel@brick> <20081126213359.GA20782@fogou.chygwyn.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , David Miller , linux-netdev , LKML To: steve@chygwyn.com Return-path: Received: from wf-out-1314.google.com ([209.85.200.175]:54769 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbYKZVtG (ORCPT ); Wed, 26 Nov 2008 16:49:06 -0500 Received: by wf-out-1314.google.com with SMTP id 27so669828wfd.4 for ; Wed, 26 Nov 2008 13:49:05 -0800 (PST) In-Reply-To: <20081126213359.GA20782@fogou.chygwyn.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2008-11-26 at 21:33 +0000, steve@chygwyn.com wrote: > Hi, > > On Wed, Nov 26, 2008 at 01:12:54PM -0800, Harvey Harrison wrote: > > Signed-off-by: Harvey Harrison > > --- > [snip] > > diff --git a/include/net/dn_fib.h b/include/net/dn_fib.h > > index 3012511..c378be7 100644 > > --- a/include/net/dn_fib.h > > +++ b/include/net/dn_fib.h > > @@ -181,9 +181,9 @@ static inline void dn_fib_res_put(struct dn_fib_res *res) > > > > static inline __le16 dnet_make_mask(int n) > > { > > - if (n) > > - return dn_htons(~((1<<(16-n))-1)); > > - return 0; > > + if (n) > > + return cpu_to_le16(~((1 << (16 - n)) - 1)); > > + return cpu_to_le16(0); > > } > You don't need to convert 0. Tell that to sparse ;-) > > [snip] > > > > @@ -327,7 +327,7 @@ int dn_username2sockaddr(unsigned char *data, int len, struct sockaddr_dn *sdn, > > int namel = 12; > > > > sdn->sdn_objnum = 0; > > - sdn->sdn_objnamel = dn_htons(0); > > + sdn->sdn_objnamel = cpu_to_le16(0); > Again, no need to convert 0 even though I did :-) Again, sparse appreciates it. > > Otherwise the patch looks good. > > Reviewed-by: Steven Whitehouse > Thanks. Harvey