Re: [PATCH 06/39] genetlink: export genl_unregister_mc_group()

Johannes Berg
2008-11-26T23:08:29Z

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]

On Wed, 2008-11-26 at 14:40 -0800, Inaky Perez-Gonzalez wrote:
> Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
> unregistering groups on the run. EXPORT_SYMBOL_GPL() is not used as
> the rest of the functions exported by this module (eg:
> genl_register_mc_group) are also not _GPL().
>
> Cleanup is currently done when unregistering a family, but there is
> no way to unregister a single multicast group due to that function not
> being exported. Seems to be a mistake as it is documented as for
> external consumption.
>
> This is needed by the WiMAX stack to be able to cleanup unused mc
> groups.

Haven't looked at the users, but you definitely need that as soon as you
need to unregister a group on the fly, so obviously

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Thomas Graf <tgraf@suug.ch>
> ---
> net/netlink/genetlink.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
> index 3e1191c..1d3dd30 100644
> --- a/net/netlink/genetlink.c
> +++ b/net/netlink/genetlink.c
> @@ -225,6 +225,7 @@ void genl_unregister_mc_group(struct genl_family *family,
> __genl_unregister_mc_group(family, grp);
> genl_unlock();
> }
> +EXPORT_SYMBOL(genl_unregister_mc_group);
>
> static void genl_unregister_mc_groups(struct genl_family *family)
> {

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]