Re: [PATCH 00/39] merge request for WiMAX kernel stack and i2400m driver v2

Marcel Holtmann
2008-12-04T13:37:19Z

Hi Johannes,

> > First two ones I plan to tackle ASAP. The dynamic_printk() stuff might take
> > longer and I was wondering if you would be ok with changing that post-29 in
> > case I were about to miss the merge window (got a few very busy weeks
> > ahead of me).
>
> Fine with me, I guess, I don't even know if the dynprintk is applicable
> (though I'd rather see you make it work if it isn't than add yet another
> huge debug macro file :) )

I switched over the Bluetooth stack to use dynamic_printk(). It is as
easy as just using pr_debug() or dev_dbg(). The rest already works
perfectly fine.

However it is either full debug or nothing. Not a fine grained stuff we
have in the iwlwifi drivers. However not sure if that is actually
needed. It confuses me more and having to unload the driver and reload
it makes me not using it a lot. The dynamic_printk() is really nice
since you can turn it on and off. And since it is on a per module basis
it was enough for Bluetooth. Not sure if that is applicable to
everything, but then it could be extended with debug levels, I guess.

Regards

Marcel