Re: [PATCH 04/39] wimax: internal API for the kernel space WiMAX stack

Inaky Perez-Gonzalez
2008-12-04T19:30:51Z

On Thursday 04 December 2008, Johannes Berg wrote:
> On Tue, 2008-12-02 at 18:07 -0800, Inaky Perez-Gonzalez wrote:
> > > > +static inline __must_check
> > > > +int wimax_dev_is_ready(struct wimax_dev *wimax_dev)
> > > > +{
> > > > + if (wimax_dev->state == __WIMAX_ST_NULL)
> > > > + return -EINVAL; /* Device is not even registered! */
> > > > + if (wimax_dev->state == WIMAX_ST_DOWN)
> > > > + return -ENOMEDIUM;
> > >
> > > ENOLINK seems more appropriate?
> >
> > Well, this means there is no medium on which to try to establish a
> > link. It doesn't really matter.
> >
> > Is it used mainly for storage applications?
>
> Yes, I think so.

Ack, I'll switch it to -ENOLINK.

Thanks,

--
Inaky