Re: [PATCH 15/39] i2400m: host-to-device protocol definitions

Johannes Berg
2008-11-27T10:05:10Z

[-- Attachment #1: Type: text/plain, Size: 1872 bytes --]

On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:

> +/* Message types */
> +enum i2400m_mt {
> + I2400M_MT_RESERVED = 0x0000,
> + I2400M_MT_INVALID = 0xffff,
> + I2400M_MT_REPORT_MASK = 0x8000,
> +
> + I2400M_MT_GET_SCAN_RESULT = 0x4202,
> + I2400M_MT_SET_SCAN_PARAM = 0x4402,
> + I2400M_MT_CMD_RF_CONTROL = 0x4602,
> + I2400M_MT_CMD_SCAN = 0x4603,
> + I2400M_MT_CMD_CONNECT = 0x4604,
> + I2400M_MT_CMD_DISCONNECT = 0x4605,
> + I2400M_MT_CMD_EXIT_IDLE = 0x4606,
> + I2400M_MT_GET_LM_VERSION = 0x5201,
> + I2400M_MT_GET_DEVICE_INFO = 0x5202,
> + I2400M_MT_GET_LINK_STATUS = 0x5203,
> + I2400M_MT_GET_STATISTICS = 0x5204,
> + I2400M_MT_GET_STATE = 0x5205,
> + I2400M_MT_GET_MEDIA_STATUS = 0x5206,
> + I2400M_MT_SET_INIT_CONFIG = 0x5404,
> + I2400M_MT_CMD_INIT = 0x5601,
> + I2400M_MT_CMD_TERMINATE = 0x5602,
> + I2400M_MT_CMD_MODE_OF_OP = 0x5603,
> + I2400M_MT_CMD_RESET_DEVICE = 0x5604,
> + I2400M_MT_CMD_MONITOR_CONTROL = 0x5605,
> + I2400M_MT_CMD_ENTER_POWERSAVE = 0x5606,
> + I2400M_MT_GET_TLS_OPERATION_RESULT = 0x6201,
> + I2400M_MT_SET_EAP_SUCCESS = 0x6402,
> + I2400M_MT_SET_EAP_FAIL = 0x6403,
> + I2400M_MT_SET_EAP_KEY = 0x6404,
> + I2400M_MT_CMD_SEND_EAP_RESPONSE = 0x6602,
> + I2400M_MT_REPORT_SCAN_RESULT = 0xc002,
> + I2400M_MT_REPORT_STATE = 0xd002,
> + I2400M_MT_REPORT_POWERSAVE_READY = 0xd005,
> + I2400M_MT_REPORT_EAP_REQUEST = 0xe002,
> + I2400M_MT_REPORT_EAP_RESTART = 0xe003,
> + I2400M_MT_REPORT_ALT_ACCEPT = 0xe004,
> + I2400M_MT_REPORT_KEY_REQUEST = 0xe005,

Since this is all device-specific, this is like implementing all of
802.11 management with iwpriv. Do you really want that? Why wouldn't
most of these commands port over to other hardware?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]