Re: [PATCH 04/39] wimax: internal API for the kernel space WiMAX stack

Inaky Perez-Gonzalez
2008-12-03T02:11:31Z

On Thursday 27 November 2008, Johannes Berg wrote:
> On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:

> > +static inline __must_check
> > +int wimax_dev_is_ready(struct wimax_dev *wimax_dev)
> > +{
> > + if (wimax_dev->state == __WIMAX_ST_NULL)
> > + return -EINVAL; /* Device is not even registered! */
> > + if (wimax_dev->state == WIMAX_ST_DOWN)
> > + return -ENOMEDIUM;
>
> ENOLINK seems more appropriate?

Well, this means there is no medium on which to try to establish a
link. It doesn't really matter.

Is it used mainly for storage applications?

> > +/*
> > + * The concept of a pipe -- we encapsulate it because we want to
> > + * detach the usage of it from the implementation, and thus it serves
> > + * just as a handle.
>
> Might help to explain just what the concept is :)

Yes, that required some documentation fixes; added, thanks.

--
Inaky