From: "Denis V. Lunev" <den@parallels.com>
To: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] Phonet: basic net namespace support
Date: Mon, 01 Dec 2008 15:17:49 +0300 [thread overview]
Message-ID: <1228133869.10480.10.camel@iris.sw.ru> (raw)
In-Reply-To: <1228132957-18373-1-git-send-email-remi.denis-courmont@nokia.com>
On Mon, 2008-12-01 at 14:02 +0200, Rémi Denis-Courmont wrote:
[snip]
> -int phonet_address_lookup(u8 addr)
> +int phonet_address_lookup(struct net *net, u8 addr)
> {
> struct phonet_device *pnd;
>
> spin_lock_bh(&pndevs.lock);
> list_for_each_entry(pnd, &pndevs.list, list) {
> + if (dev_net(pnd->netdev) != net)
> + continue;
net_eq is better (noop without netns). also there are some similar
places below
Regards,
Den
next prev parent reply other threads:[~2008-12-01 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 12:02 [PATCH net-next] Phonet: basic net namespace support Rémi Denis-Courmont
2008-12-01 12:17 ` Denis V. Lunev [this message]
2008-12-01 12:36 ` Rémi Denis-Courmont
2008-12-01 12:37 ` [PATCH net] Phonet: do not dump addresses from other namespaces Rémi Denis-Courmont
2008-12-01 12:37 ` [PATCH net-next] Phonet: basic net namespace support Rémi Denis-Courmont
2008-12-03 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228133869.10480.10.camel@iris.sw.ru \
--to=den@parallels.com \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).