netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk
@ 2008-12-01 22:01 akpm
  2008-12-01 22:03 ` Marcel Holtmann
  0 siblings, 1 reply; 4+ messages in thread
From: akpm @ 2008-12-01 22:01 UTC (permalink / raw)
  To: davem
  Cc: linux-bluetooth, netdev, akpm, mario_limonciello, hidave.darkstar,
	marcel, stable, tim.gardner

From: Mario Limonciello <mario_limonciello@dell.com>

This patch causes the BT365 to be reset when the driver is loaded. 
Without it, the machine is unable to connect to other devices or to scan
for devices.

Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Dave Young <hidave.darkstar@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/bluetooth/btusb.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk drivers/bluetooth/btusb.c
--- a/drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk
+++ a/drivers/bluetooth/btusb.c
@@ -125,6 +125,9 @@ static struct usb_device_id blacklist_ta
 	/* Dell laptop with Broadcom chip */
 	{ USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
 
+	/* Dell Wireless 365 */
+	{ USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET },
+
 	/* Dell Wireless 370 */
 	{ USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
 
_

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk
  2008-12-01 22:01 [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk akpm
@ 2008-12-01 22:03 ` Marcel Holtmann
       [not found]   ` <1228169030.31158.154.camel-Q5NHXjiL5LzjRizqIHwDm9HuzzzSOjJt@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2008-12-01 22:03 UTC (permalink / raw)
  To: akpm
  Cc: davem, linux-bluetooth, netdev, mario_limonciello,
	hidave.darkstar, stable, tim.gardner

Hi Andrew,

> This patch causes the BT365 to be reset when the driver is loaded. 
> Without it, the machine is unable to connect to other devices or to scan
> for devices.
> 
> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Dave Young <hidave.darkstar@gmail.com>
> Cc: <stable@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

NAK. I fixed this differently by making the reset quirk default.

Regards

Marcel



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk
       [not found]   ` <1228169030.31158.154.camel-Q5NHXjiL5LzjRizqIHwDm9HuzzzSOjJt@public.gmane.org>
@ 2008-12-02  0:12     ` Tim Gardner
       [not found]       ` <49347D69.7070807-l6nL5VImRDY@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Tim Gardner @ 2008-12-02  0:12 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q,
	linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA, mario_limonciello-8PEkshWhKlo,
	hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w,
	stable-DgEjT+Ai2ygdnm+yROfE0A, tim.gardner-Z7WLFzj8eWMS+FvcfC7Uqw

Marcel Holtmann wrote:
> Hi Andrew,
> 
>> This patch causes the BT365 to be reset when the driver is loaded. 
>> Without it, the machine is unable to connect to other devices or to scan
>> for devices.
>>
>> Signed-off-by: Mario Limonciello <mario_limonciello-8PEkshWhKlo@public.gmane.org>
>> Signed-off-by: Tim Gardner <tim.gardner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>> Cc: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
>> Cc: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: <stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> 
> NAK. I fixed this differently by making the reset quirk default.
> 
> Regards
> 
> Marcel
> 
> 

Does that mean the devices in blacklist_table that have _only_
BTUSB_RESET should be removed? It would get rid of roughly half of the
entries.

rtg
-- 
Tim Gardner tim.gardner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk
       [not found]       ` <49347D69.7070807-l6nL5VImRDY@public.gmane.org>
@ 2008-12-02  0:22         ` Marcel Holtmann
  0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2008-12-02  0:22 UTC (permalink / raw)
  To: tim.gardner-Z7WLFzj8eWMS+FvcfC7Uqw
  Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q,
	linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA, mario_limonciello-8PEkshWhKlo,
	hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w,
	stable-DgEjT+Ai2ygdnm+yROfE0A

Hi Tim,

> >> This patch causes the BT365 to be reset when the driver is loaded. 
> >> Without it, the machine is unable to connect to other devices or to scan
> >> for devices.
> >>
> >> Signed-off-by: Mario Limonciello <mario_limonciello-8PEkshWhKlo@public.gmane.org>
> >> Signed-off-by: Tim Gardner <tim.gardner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> >> Cc: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
> >> Cc: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> Cc: <stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >> Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> > 
> > NAK. I fixed this differently by making the reset quirk default.
>
> Does that mean the devices in blacklist_table that have _only_
> BTUSB_RESET should be removed? It would get rid of roughly half of the
> entries.

that has already been done. See the pull request I sent to Dave.

Regards

Marcel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-12-02  0:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 22:01 [patch for 2.6.28? 1/1] bluetooth: Dell Wireless 365 requires reset quirk akpm
2008-12-01 22:03 ` Marcel Holtmann
     [not found]   ` <1228169030.31158.154.camel-Q5NHXjiL5LzjRizqIHwDm9HuzzzSOjJt@public.gmane.org>
2008-12-02  0:12     ` Tim Gardner
     [not found]       ` <49347D69.7070807-l6nL5VImRDY@public.gmane.org>
2008-12-02  0:22         ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).