From: Daniel Silverstone <dsilvers@simtec.co.uk>
To: David Miller <davem@davemloft.net>
Cc: hch@infradead.org, netdev@vger.kernel.org
Subject: Re: [Patch] Micrel KS8695 intergrated ethernet driver
Date: Tue, 09 Dec 2008 09:29:31 +0000 [thread overview]
Message-ID: <1228814971.11905.2.camel@petitemort> (raw)
In-Reply-To: <20081209.010529.57138453.davem@davemloft.net>
On Tue, 2008-12-09 at 01:05 -0800, David Miller wrote:
> > > > > + mapping = dma_map_single(ksp->dev, skb->data,
> > > > > + MAX_RXBUF_SIZE,
> > > > > + DMA_FROM_DEVICE);
> > > > I take it that dma_map_single() can never fail on ARM?
> > > No it can't. It essentially boils down to some pointer arithmetic on
> > > this platform.
> > You should check for errors anyway. The driver might be ported to an
> > architecture where it can fail (e.g. the SOC block gets reused), ARM
> > variants may come up where it can fail, or people might use the driver
> > as an example for their own new driver.
> Agreed.
Very well, I shall sort out an ammended patch. Thanks for your help in
reviewing the code.
Regards,
Daniel.
--
Daniel Silverstone http://www.simtec.co.uk/
PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895
next prev parent reply other threads:[~2008-12-09 9:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 15:06 [Patch] Micrel KS8695 intergrated ethernet driver Daniel Silverstone
2008-12-05 17:57 ` Ben Hutchings
2008-12-08 11:05 ` Daniel Silverstone
2008-12-08 15:17 ` Ben Hutchings
2008-12-08 20:29 ` David Miller
2008-12-09 8:57 ` Christoph Hellwig
2008-12-09 9:05 ` David Miller
2008-12-09 9:29 ` Daniel Silverstone [this message]
2008-12-13 19:07 ` Kalle Valo
2008-12-08 13:08 ` Daniel Silverstone
2008-12-09 17:00 ` Daniel Silverstone
[not found] ` <1228764912.3177.39.camel@achroite>
2008-12-09 17:30 ` [Patch] Micrel KS8695 integrated " Daniel Silverstone
2008-12-09 18:10 ` Ben Hutchings
2008-12-10 7:05 ` David Miller
2008-12-10 15:41 ` Daniel Silverstone
2008-12-12 5:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228814971.11905.2.camel@petitemort \
--to=dsilvers@simtec.co.uk \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).